This repository was archived by the owner on Jun 9, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
Simplify models, fix typing #23
Merged
Merged
Changes from 23 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
2058a90
Remove __post_init__ functions
AdrienVannson 03ffb51
Remove __post_init__ from MessageCompiler
AdrienVannson 1338711
Remove outdated comment
AdrienVannson 8b03ce1
Fix typing error
AdrienVannson 16e33ab
Fix typing error
AdrienVannson f22c6b6
Remove placeholders
AdrienVannson 2757e56
Remove comment
AdrienVannson e12a476
Remove parent property from ProtoContentBase
AdrienVannson 4ea2ec8
Simplify annotations
AdrienVannson e006a20
Rename parent variable
AdrienVannson d54916f
Remove useless method
AdrienVannson c1230f7
Fix bug
AdrienVannson c797cab
Fix bug
AdrienVannson a3fb00a
Move deprecated function
AdrienVannson 0e19445
Fix typing errors
AdrienVannson 9f305b6
Remove useless code
AdrienVannson 6e043ca
Fix typing error in code validation
AdrienVannson 3d25c79
Fix typing error
AdrienVannson dd541b9
Fix typin gerrors with unwrap
AdrienVannson 38279fa
Add pyright
AdrienVannson d90adcc
Poe command for pyright
AdrienVannson 6b3abc9
Use pyright in workflow
AdrienVannson e6e4575
Typecheck only source code for now
AdrienVannson 366496f
Use poetry command
AdrienVannson 500062a
Don't make EnumDefinitionCompiler inherit from MessageCompiler
AdrienVannson 3ce8feb
Fix inheritance
AdrienVannson 69feb66
Fix workflow permissions
AdrienVannson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,10 +9,40 @@ | |
- '**' | ||
|
||
jobs: | ||
check-formatting: | ||
name: Check code/doc formatting | ||
check: | ||
name: Check code formatting, typecheck the code | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v3 | ||
- uses: actions/setup-python@v4 | ||
- uses: actions/checkout@v4 | ||
- uses: actions/setup-python@v5 | ||
|
||
- name: Install poetry | ||
shell: bash | ||
run: | | ||
python -m pip install poetry | ||
echo "$HOME/.poetry/bin" >> $GITHUB_PATH | ||
|
||
- name: Configure poetry | ||
shell: bash | ||
run: poetry config virtualenvs.in-project true | ||
|
||
- name: Set up cache | ||
uses: actions/cache@v3 | ||
id: cache | ||
with: | ||
path: .venv | ||
key: venv-quality-${{ hashFiles('**/poetry.lock') }} | ||
|
||
- name: Ensure cache is healthy | ||
if: steps.cache.outputs.cache-hit == 'true' | ||
shell: bash | ||
run: poetry run pip --version >/dev/null 2>&1 || rm -rf .venv | ||
|
||
- name: Install dependencies | ||
shell: bash | ||
run: poetry install | ||
|
||
- uses: pre-commit/[email protected] | ||
- uses: jakebailey/pyright-action@v2 | ||
Check warning on line 46 in .github/workflows/code-quality.yml
|
||
|
||
with: | ||
working-directory: src | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.