This repository was archived by the owner on Jun 9, 2025. It is now read-only.
Message wrapping #65
Merged
Message wrapping #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- src/betterproto2_compiler/templates/header.py.j2: Language not supported
Comments suppressed due to low confidence (1)
src/betterproto2_compiler/plugin/models.py:338
- The 'field_wraps' property has been removed from the diff, which might break external references if it is used anywhere outside this file. Please verify that all dependencies on this property have been updated to use the new wrapping logic.
def field_wraps(self) -> str | None:
| casing: betterproto2.Casing = betterproto2.Casing.CAMEL, | ||
| include_default_values: bool = False, | ||
| ) -> dict[str, typing.Any] | typing.Any: | ||
| # If the output format is PYTHON, we should have kept the wraped type without building the real class |
There was a problem hiding this comment.
There is a spelling error: 'wraped' should be corrected to 'wrapped'.
Suggested change
| # If the output format is PYTHON, we should have kept the wraped type without building the real class | |
| # If the output format is PYTHON, we should have kept the wrapped type without building the real class |
Copilot uses AI. Check for mistakes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.