Skip to content

Add ruff check, remove outdated benchmark #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AdrienVannson merged 3 commits into from
Jan 27, 2025
Merged

Add ruff check, remove outdated benchmark #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
43712f4
Add ruff check
AdrienVannson Jan 27, 2025
35a6c06
Remove outdated benchmark
AdrienVannson Jan 27, 2025
6817b59
Poetry lock
AdrienVannson Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
157 changes: 0 additions & 157 deletions asv.conf.json
View file
Open in desktop

This file was deleted.

Empty file removed benchmarks/__init__.py
View file
Open in desktop
Empty file.
117 changes: 0 additions & 117 deletions benchmarks/benchmarks.py
View file
Open in desktop

This file was deleted.

19 changes: 1 addition & 18 deletions poetry.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

23 changes: 8 additions & 15 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ typing-extensions = "^4.7.1"
betterproto2-rust-codec = { version = "^0.1.2", optional = true }

[tool.poetry.group.dev.dependencies]
asv = "^0.4.2"
mypy = "^1.11.2"
pre-commit = "^2.17.0"
tox = "^4.0.0"
Expand All @@ -53,7 +52,7 @@ protobuf = "^4"
cachelib = "^0.10.2"

[tool.ruff]
extend-exclude = ["tests/output_*", "src/betterproto2/lib"]
extend-exclude = ["tests/output_*", "src/betterproto2/internal_lib"]
target-version = "py310"
line-length = 120

Expand All @@ -68,6 +67,8 @@ select = [
"SIM102", # Simplify return or yield statements
"SIM103", # Simplify list/set/dict comprehensions

"UP",

"I",
]

Expand Down Expand Up @@ -96,7 +97,7 @@ sequence = ["_format", "_sort-imports"]
help = "Format the source code, and sort the imports"

[tool.poe.tasks.check]
sequence = ["_check-format", "_check-imports"]
sequence = ["_check-format", "_check"]
help = "Check that the source code is formatted and the imports sorted"

[tool.poe.tasks._format]
Expand All @@ -111,21 +112,13 @@ help = "Sort the imports"
cmd = "ruff format --diff src tests"
help = "Check that the source code is formatted"

[tool.poe.tasks._check-imports]
cmd = "ruff check --select I src tests"
help = "Check that the imports are sorted"

[tool.poe.tasks.docs]
cmd = "sphinx-build docs docs/build"
help = "Build the sphinx docs"

[tool.poe.tasks.bench]
shell = "asv run master^! && asv run HEAD^! && asv compare master HEAD"
help = "Benchmark current commit vs. master branch"
[tool.poe.tasks._check]
cmd = "ruff check src tests"
help = "Check the code"

[tool.poe.tasks.clean]
cmd = """
rm -rf .asv .coverage .mypy_cache .pytest_cache
rm -rf .coverage .mypy_cache .pytest_cache
dist betterproto.egg-info **/__pycache__
testsoutput_*
"""
Expand Down
Loading
Loading