Skip to content

Make grpclib optional #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AdrienVannson merged 4 commits into from
Jan 27, 2025
Merged

Make grpclib optional #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a3b8135
Make grpclib optional
AdrienVannson Jan 27, 2025
cbd6a9b
Update CI
AdrienVannson Jan 27, 2025
0bd9318
Add all extra
AdrienVannson Jan 27, 2025
a3c1108
Update documentation
AdrienVannson Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ jobs:

- name: Install dependencies
shell: bash
run: poetry install
run: poetry install -E grpc-async

- name: Download compiled test files
shell: bash
Expand All @@ -66,7 +66,7 @@ jobs:

- name: Install dependencies with the Rust codec
shell: bash
run: poetry install -E rust-codec
run: poetry install -E grpc-async -E rust-codec

- name: Execute test suite with the Rust codec
shell: bash
Expand Down
2 changes: 1 addition & 1 deletion docs/getting-started.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Getting Started
The package `betterproto2` can be simply installed from PyPI using `pip`:

```sh
pip install betterproto2
pip install betterproto2[all]
```

!!! info
Expand Down
14 changes: 8 additions & 6 deletions poetry.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,16 @@ Repository = "https://github.com/betterproto/python-betterproto2"

[project.optional-dependencies]
rust-codec = ["betterproto2-rust-codec"]
grpc-async = ["grpclib"]
all = ["betterproto2-rust-codec", "grpclib"]

[tool.poetry]
packages = [
{ include = "betterproto2", from = "src" }
]

[tool.poetry.dependencies]
grpclib = "^0.4.1"
grpclib = { version = "^0.4.1", optional = true }
python-dateutil = "^2.8"
typing-extensions = "^4.7.1"
betterproto2-rust-codec = { version = "^0.1.2", optional = true }
Expand Down
Loading