Commit 5ac16eb
authored
Fix: Ignores nodes that are hidden via their parents in directional nav (#22123)
# Objective
- Fixes #21950
## Solution
- Updated the query as suggested in the issue to also check for
`InheritedVisibility`. Entities that have `Visibility::INHERITED` and
`InheritedVisibility::HIDDEN` should also be ignored for directional
navigation
## Testing
- Did you test these changes? If so, how?
I did not test this change at all! And I wasn’t sure how best to set up
an automated test for this since there is not an existing one for that
function, else I would have. However, the logic change is simple at
least… So if a test is desired, just let me know and please provide me
with a little direction :)1 parent 0303bd6 commit 5ac16eb
File tree
1 file changed
+20
-13
lines changed- crates/bevy_input_focus/src
1 file changed
+20
-13
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
60 | 60 | | |
61 | 61 | | |
62 | 62 | | |
63 | | - | |
| 63 | + | |
64 | 64 | | |
65 | 65 | | |
66 | 66 | | |
| |||
749 | 749 | | |
750 | 750 | | |
751 | 751 | | |
| 752 | + | |
752 | 753 | | |
753 | 754 | | |
754 | 755 | | |
| |||
759 | 760 | | |
760 | 761 | | |
761 | 762 | | |
762 | | - | |
763 | | - | |
764 | | - | |
765 | | - | |
766 | | - | |
767 | | - | |
768 | | - | |
769 | | - | |
770 | | - | |
771 | | - | |
772 | | - | |
773 | | - | |
| 763 | + | |
| 764 | + | |
| 765 | + | |
| 766 | + | |
| 767 | + | |
| 768 | + | |
| 769 | + | |
| 770 | + | |
| 771 | + | |
| 772 | + | |
| 773 | + | |
| 774 | + | |
| 775 | + | |
| 776 | + | |
| 777 | + | |
| 778 | + | |
| 779 | + | |
| 780 | + | |
774 | 781 | | |
775 | 782 | | |
776 | 783 | | |
| |||
0 commit comments