Fix wireframe and examples with mesh pipeline set (#23147)

# Objective

- #22443 broke wireframe and some examples

## Solution

- Fix them by having the systems run after `MeshPipelineSet`
- Also add a migration guide

## Testing

- run the examples modified or anything using wireframe

Author: mockersf

crates/bevy_pbr/src/wireframe.rs

@@ -1,8 +1,8 @@
 use crate::{
     render::{PreprocessBindGroups, PreprocessPipelines},
-    DrawMesh, MeshPipeline, MeshPipelineKey, RenderLightmaps, RenderMeshInstanceFlags,
-    RenderMeshInstances, SetMeshBindGroup, SetMeshViewBindGroup, SetMeshViewBindingArrayBindGroup,
-    ViewKeyCache,
+    DrawMesh, MeshPipeline, MeshPipelineKey, MeshPipelineSet, RenderLightmaps,
+    RenderMeshInstanceFlags, RenderMeshInstances, SetMeshBindGroup, SetMeshViewBindGroup,
+    SetMeshViewBindingArrayBindGroup, ViewKeyCache,
 };
 use bevy_app::{App, Plugin, PostUpdate, Startup, Update};
 use bevy_asset::{
@@ -149,7 +149,10 @@ impl Plugin for WireframePlugin {
             .init_resource::<WireframeWideBindGroups>()
             .init_resource::<SpecializedMeshPipelines<Wireframe3dPipeline>>()
             .init_resource::<PendingWireframeQueues>()
-            .add_systems(RenderStartup, init_wireframe_3d_pipeline)
+            .add_systems(
+                RenderStartup,
+                init_wireframe_3d_pipeline.after(MeshPipelineSet),
+            )
             .add_systems(
                 Core3d,
                 wireframe_3d

examples/shader_advanced/custom_render_phase.rs

@@ -15,7 +15,7 @@ use std::ops::Range;
 use bevy::camera::Viewport;
 use bevy::core_pipeline::core_3d::TransparentSortingInfo3d;
 use bevy::math::Affine3Ext;
-use bevy::pbr::{SetMeshViewEmptyBindGroup, ViewKeyCache};
+use bevy::pbr::{MeshPipelineSet, SetMeshViewEmptyBindGroup, ViewKeyCache};
 use bevy::{
     camera::MainPassResolutionOverride,
     core_pipeline::{core_3d::main_opaque_pass_3d, schedule::Core3d, Core3dSystems},
@@ -131,7 +131,7 @@ impl Plugin for MeshStencilPhasePlugin {
             .add_render_command::<Stencil3d, DrawMesh3dStencil>()
             .init_resource::<ViewSortedRenderPhases<Stencil3d>>()
             .init_resource::<PendingCustomMeshQueues>()
-            .add_systems(RenderStartup, init_stencil_pipeline)
+            .add_systems(RenderStartup, init_stencil_pipeline.after(MeshPipelineSet))
             .add_systems(ExtractSchedule, extract_camera_phases)
             .add_systems(
                 Render,

examples/shader_advanced/custom_shader_instancing.rs

@@ -8,7 +8,7 @@
 //! It's generally recommended to try the built-in instancing before going with this approach.
 
 use bevy::core_pipeline::core_3d::TransparentSortingInfo3d;
-use bevy::pbr::{SetMeshViewBindingArrayBindGroup, ViewKeyCache};
+use bevy::pbr::{MeshPipelineSet, SetMeshViewBindingArrayBindGroup, ViewKeyCache};
 use bevy::{
     camera::visibility::NoFrustumCulling,
     core_pipeline::core_3d::Transparent3d,
@@ -107,7 +107,7 @@ impl Plugin for CustomMaterialPlugin {
         app.sub_app_mut(RenderApp)
             .add_render_command::<Transparent3d, DrawCustom>()
             .init_resource::<SpecializedMeshPipelines<CustomPipeline>>()
-            .add_systems(RenderStartup, init_custom_pipeline)
+            .add_systems(RenderStartup, init_custom_pipeline.after(MeshPipelineSet))
             .add_systems(
                 Render,
                 (

examples/shader_advanced/specialized_mesh_pipeline.rs

@@ -14,8 +14,9 @@ use bevy::{
     math::{vec3, vec4},
     mesh::{Indices, MeshVertexBufferLayoutRef, PrimitiveTopology},
     pbr::{
-        DrawMesh, MeshPipeline, MeshPipelineKey, MeshPipelineViewLayoutKey, RenderMeshInstances,
-        SetMeshBindGroup, SetMeshViewBindGroup, SetMeshViewEmptyBindGroup, ViewKeyCache,
+        DrawMesh, MeshPipeline, MeshPipelineKey, MeshPipelineSet, MeshPipelineViewLayoutKey,
+        RenderMeshInstances, SetMeshBindGroup, SetMeshViewBindGroup, SetMeshViewEmptyBindGroup,
+        ViewKeyCache,
     },
     prelude::*,
     render::{
@@ -115,7 +116,10 @@ impl Plugin for CustomRenderedMeshPipelinePlugin {
             .init_resource::<PendingCustomMeshQueues>()
             // We need to use a custom draw command so we need to register it
             .add_render_command::<Opaque3d, DrawSpecializedPipelineCommands>()
-            .add_systems(RenderStartup, init_custom_mesh_pipeline)
+            .add_systems(
+                RenderStartup,
+                init_custom_mesh_pipeline.after(MeshPipelineSet),
+            )
             .add_systems(
                 Render,
                 queue_custom_mesh_pipeline.in_set(RenderSystems::Queue),

release-content/migration-guides/meshpipelineset-renderstartup-systems.md

@@ -0,0 +1,6 @@
+---
+title: Resources `MeshPipelineViewLayouts`, `MeshPipeline` and `RenderDebugOverlayPipeline` are now created in `RenderStartup` systems
+pull_requests: [22443]
+---
+
+Systems using the `MeshPipelineViewLayouts`, `MeshPipeline` and `RenderDebugOverlayPipeline` resources in the `RenderStartup` schedule now need to be run after the `MeshPipelineSet` system set.