Skip to content

Commit a590adc

Browse files
mdickoppmockersf
authored andcommitted
Fix confusing comment in pbr example (#16996)
After a recent fix for a panic in the pbr example (#16976), the code contains the following comment: ```rust // This system relies on system parameters that are not available at start // Ignore parameter failures so that it will run when possible .add_systems(Update, environment_map_load_finish.never_param_warn()) ``` However, this explanation is incorrect. `EnvironmentMapLabel` is available at start. The real issue is that it is no longer available once it has been removed by `environment_map_load_finish`. - Remove confusing/incorrect comment and `never_param_warn()`. - Make `Single<Entity, With<EnvironmentMapLabel>>` optional in `environment_map_load_finish`, and check that the entity has not yet been despawned. Since it is expected that an entity is no longer there once it has been despawned, it seems better to me to handle this case in `environment_map_load_finish`. Ran `cargo run --example pbr`.
1 parent f8bd514 commit a590adc

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

examples/3d/pbr.rs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,7 @@ fn main() {
77
App::new()
88
.add_plugins(DefaultPlugins)
99
.add_systems(Startup, setup)
10-
// This system relies on system parameters that are not available at start
11-
// Ignore parameter failures so that it will run when possible
12-
.add_systems(Update, environment_map_load_finish.never_param_warn())
10+
.add_systems(Update, environment_map_load_finish)
1311
.run();
1412
}
1513

0 commit comments

Comments
 (0)