clippy

Author: beicause

crates/bevy_asset/src/io/source.rs

@@ -12,7 +12,7 @@ use bevy_ecs::resource::Resource;
 use bevy_platform::collections::HashMap;
 use core::{fmt::Display, hash::Hash, time::Duration};
 use thiserror::Error;
-use tracing::{error, warn};
+use tracing::warn;
 
 use super::{ErasedAssetReader, ErasedAssetWriter};
 

crates/bevy_ecs/src/schedule/schedule.rs

@@ -17,7 +17,7 @@ use core::{
     fmt::{Debug, Write},
 };
 use fixedbitset::FixedBitSet;
-use log::{error, info, warn};
+use log::{info, warn};
 use pass::ScheduleBuildPassObj;
 use thiserror::Error;
 #[cfg(feature = "trace")]

crates/bevy_image/src/dynamic_texture_atlas_builder.rs

@@ -3,7 +3,6 @@ use bevy_asset::RenderAssetUsages;
 use bevy_math::{URect, UVec2};
 use guillotiere::{size2, Allocation, AtlasAllocator};
 use thiserror::Error;
-use tracing::error;
 
 /// An error produced by [`DynamicTextureAtlasBuilder`] when trying to add a new
 /// texture to a [`TextureAtlasLayout`].

crates/bevy_render/src/view/window/screenshot.rs

@@ -644,8 +644,8 @@ pub(crate) fn collect_screenshots(world: &mut World) {
             // The polling for this map call is done every frame when the command queue is submitted.
             buffer_slice.map_async(wgpu::MapMode::Read, move |result| {
                 let err = result.err();
-                if err.is_some() {
-                    panic!("{}", err.unwrap().to_string());
+                if let Some(e) = err {
+                    panic!("{}", e.to_string());
                 }
                 tx.try_send(()).unwrap();
             });

crates/bevy_shader/src/shader_cache.rs

@@ -5,7 +5,7 @@ use bevy_platform::collections::{hash_map::EntryRef, HashMap, HashSet};
 use core::hash::Hash;
 use naga::valid::Capabilities;
 use thiserror::Error;
-use tracing::{debug, error};
+use tracing::debug;
 use wgpu_types::{DownlevelFlags, Features};
 
 /// Source of a shader module.