Raise compile error when using non-static lifetimes in #[derive(Resource)] (#21385)

# Objective

Fixes #20413 

Adding non-static lifetimes to `#[derive(Resource)]` should not compile.

## Solution

Added a check in the derive macro of `Resource` to ensure all lifetime
generics are bound to 'static, if not it raises an error.

## Testing

Added a ui-test for compile error.

---------

Co-authored-by: Chris Russell <[email protected]>

Author: VasanthakumarV

crates/bevy_ecs/compile_fail/tests/ui/resource_derive.rs

@@ -0,0 +1,12 @@
+use bevy_ecs::prelude::*;
+
+#[derive(Resource)]
+//~v ERROR: Lifetimes must be 'static
+struct A<'a> {
+    foo: &'a str,
+}
+
+#[derive(Resource)]
+struct B<'a: 'static> {
+    foo: &'a str,
+}

crates/bevy_ecs/compile_fail/tests/ui/resource_derive.stderr

@@ -0,0 +1,8 @@
+error: Lifetimes must be 'static
+ --> tests/ui/resource_derive.rs:5:10
+  |
+5 | struct A<'a> {
+  |          ^^
+
+error: aborting due to 1 previous error
+

crates/bevy_ecs/macros/src/component.rs

@@ -17,6 +17,21 @@ pub fn derive_resource(input: TokenStream) -> TokenStream {
     let mut ast = parse_macro_input!(input as DeriveInput);
     let bevy_ecs_path: Path = crate::bevy_ecs_path();
 
+    // We want to raise a compile time error when the generic lifetimes
+    // are not bound to 'static lifetime
+    let non_static_lifetime_error = ast
+        .generics
+        .lifetimes()
+        .filter(|lifetime| !lifetime.bounds.iter().any(|bound| bound.ident == "static"))
+        .map(|param| syn::Error::new(param.span(), "Lifetimes must be 'static"))
+        .reduce(|mut err_acc, err| {
+            err_acc.combine(err);
+            err_acc
+        });
+    if let Some(err) = non_static_lifetime_error {
+        return err.into_compile_error().into();
+    }
+
     ast.generics
         .make_where_clause()
         .predicates

release-content/migration-guides/derive_compile_error_for_non_static_resource.md

@@ -0,0 +1,15 @@
+---
+title: Derive on Resource will fail when using non-static lifetimes
+pull_requests: [21385]
+---
+
+Any type with `#[derive(Resource)]` that uses non-static lifetime will no longer compile.
+
+```rust
+// Will no longer compile in 0.18,
+// 'a should be 'static
+#[derive(Resource)]
+struct Foo<'a> {
+   bar: &'a str
+}
+```