Skip to content

Commit d9ba1af

Browse files
Fix Typo in bevy_platform_support's spin Feature (#17516)
# Objective - Fix typo in `spin/portable-atomic` feature. ## Solution - Replace with `spin/portable_atomic` ## Testing - CI --- ## Notes This is a very annoying design choice the `spin` developers made. Because the _crate_ is called `portable-atomic` and is optional, Cargo automatically registers the feature `portable-atomic`. But the maintainers use `portable_atomic` for their _feature_ which enables the support. Sneaks through CI because it's a valid feature and will only cause breakage on atomically challenged platforms (which we currently aren't testing in CI). Should we test atomically challenged in CI? Right now I don't think so, at least not until we've made "normal" `no_std` CI better with the main `bevy` crate as the test-case rather than each individual crate.
1 parent 94e0e1f commit d9ba1af

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

crates/bevy_platform_support/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ critical-section = ["dep:critical-section", "portable-atomic?/critical-section"]
4141
portable-atomic = [
4242
"dep:portable-atomic",
4343
"dep:portable-atomic-util",
44-
"spin/portable-atomic",
44+
"spin/portable_atomic",
4545
]
4646

4747
[dependencies]

0 commit comments

Comments
 (0)