Weird problem with recreating mesh and collider for chunk

[p3rsik]

Hey! Can someone help me with my problem? I have a system that does chunk reloading(create new mesh, create collider(rapier3d) from that mesh, delete children(pbr bundle and collider are children to the chunk) and insert new ones). When I try to destroy block in chunk, I need to destroy it twice for the mesh and collider to update(why?).

Here is some relevant code:

• chunk reloading system:

pub fn reload_chunk(
    mut commands: Commands,
    mut meshes: ResMut<Assets<Mesh>>,
    mut materials: ResMut<Assets<StandardMaterial>>,
    mut chunk_ev: EventReader<ChunkEvent>,
    chunks_to_reload_query: Query<&Chunk>,
) {
    let material_h = materials.add(Color::WHITE);
    for chunk_event in chunk_ev.read() {
        let chunk_entity = match chunk_event {
            ChunkEvent::Reload(chunk_entity) => chunk_entity,
            _ => return,
        };
        if let Ok(chunk) = chunks_to_reload_query.get(*chunk_entity) {
            println!("Reloading chunk mesh for {:?}", chunk.translation);
            println!("New block_data = {:?}", chunk.block_data);
            let mesh = chunk.mesh();
            // apparently Collider::from_bevy_mesh panics, because of
            // assert!(indices.len() > 0), so I need to check it manually
            // Why can't you rust return Err?
            let collider = mesh.indices().and_then(|inds| {
                if !inds.is_empty() {
                    Collider::from_bevy_mesh(&mesh, &ComputedColliderShape::TriMesh)
                } else {
                    None
                }
            });
            let mesh = meshes.add(mesh);

            if let Some(collider) = collider {
                if let Some(mut chunk_commands) = commands.get_entity(*chunk_entity) {
                    println!("adding new collider");
                    chunk_commands.despawn_descendants();
                    chunk_commands.with_children(|parent| {
                        parent.spawn((
                            PbrBundle {
                                mesh,
                                material: material_h.clone(),
                                transform: Transform::from_translation(Vec3::splat(0.0)),
                                ..default()
                            },
                            RigidBody::Fixed,
                            collider,
                        ));
                    });
                }
            }
        }
    }
}

destroy object system:

pub fn destroy_object(
    buttons: Res<ButtonInput<MouseButton>>,
    mut chunk_ev: EventWriter<ChunkEvent>,
    looking_at_query: Query<(&Parent, &LookingAt)>,
    mut chunk_query: Query<(&mut Chunk, &GlobalTransform)>,
) {
    if buttons.just_pressed(MouseButton::Left) {
        for (chunk_entity, looking_at) in looking_at_query.iter() {
            // TODO Check if this solution is okay
            // block always has one parent and it's its chunk
            let (mut chunk, transform) = chunk_query.get_mut(chunk_entity.get()).unwrap();
            let (_scale, _rot, tr) = transform.to_scale_rotation_translation();
            println!(
                "removing block from {:?} with global transform {}",
                chunk.translation, tr
            );
            println!("{:?}", looking_at);
            let local_pos = chunk.get_local_block_pos(&looking_at.block_pos);
            chunk.remove_block_at(&local_pos);
            chunk_ev.send(ChunkEvent::Reload(chunk_entity.get()));
        }
    }
}

and system ordering:

            .add_event::<ChunkEvent>()
            .configure_sets(
                Update,
                (ChunkSystems::PlayerInput, ChunkSystems::ChunkReload).chain(),
            )
            .add_systems(
                Update,
                (
                    (show_chunk_border.run_if(resource_equals(ShowChunks::Show))),
                    (
                        mark_chunks,
                        create_object,
                        destroy_object,
                        toggle_show_chunks,
                    )
                        .in_set(ChunkSystems::PlayerInput),
                    (load_chunks, unload_chunks, reload_chunk)
                        .in_set(ChunkSystems::ChunkReload)
                        .run_if(on_event::<ChunkEvent>()),
                ),
            );

When I run the game and break a block, I can see(through println's that block is broken, block_data in chunk is updated and mesh & collider are update too, but in game it stays the same. Only after I break it a second time it actually reloads chunk mesh and collider.

[MiniaczQ]

discord msg
hopefully this is it

[p3rsik]

@MiniaczQ Yeah, you`re right, thank you very much! It was bugging me crazy