You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have noticed that the system_meta.clone() function performs unnecessary memory copies, particularly for its fields component_access_set and archetype_component_access. However, it seems that these fields are not used in subsequent executions, such as in the param_set.p0() function. Therefore, I modified the code to use a different function that simply sets component_access_set and archetype_component_access to default values (without any memory allocation). After adding some systems to my app and executing the update method, the execution time of app.update decreased from 70us to 14us. Please note that this was an experimental modification, as I am not familiar with the internal implementation of ECS. Perhaps it is possible to modify system_meta in ParamSet to be of type &SystemMeta?
Additionally, I have performance test screenshots comparing the before and after results. Unfortunately, I am unable to provide them here. Could you please reserve a space for those screenshots in the final summary?
Thank you for your attention to this optimization request.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
-
I would like to request an optimization for the ParamSet::get_param function in the library. Currently, the code for the function is as follows:
I have noticed that the system_meta.clone() function performs unnecessary memory copies, particularly for its fields component_access_set and archetype_component_access. However, it seems that these fields are not used in subsequent executions, such as in the param_set.p0() function. Therefore, I modified the code to use a different function that simply sets component_access_set and archetype_component_access to default values (without any memory allocation). After adding some systems to my app and executing the update method, the execution time of app.update decreased from 70us to 14us. Please note that this was an experimental modification, as I am not familiar with the internal implementation of ECS. Perhaps it is possible to modify system_meta in ParamSet to be of type &SystemMeta?
Additionally, I have performance test screenshots comparing the before and after results. Unfortunately, I am unable to provide them here. Could you please reserve a space for those screenshots in the final summary?
Thank you for your attention to this optimization request.
Beta Was this translation helpful? Give feedback.
All reactions