Skip to content

unsound call to default_error_handler #22133

@hymm

Description

@hymm

Bevy version and features

What went wrong

This call to default system handler is unsound:
https://github.com/bevyengine/bevy/pull/20671/changes#diff-0e47efcf16c3678b59327508ac55eb70852f97c045dc1c4033aa57d8d3a34b5eR177

default_system_handler reads the DefaultErrorHandler resource, but SystemCombinator doesn't register read access to that resource.

Potential Fix

  • We could register the access in System::initialize

Metadata

Metadata

Assignees

Labels

A-ECSEntities, components, systems, and eventsC-BugAn unexpected or incorrect behaviorD-StraightforwardSimple bug fixes and API improvements, docs, test and examplesP-UnsoundA bug that results in undefined compiler behaviorS-Ready-For-ImplementationThis issue is ready for an implementation PR. Go for it!

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions