-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Closed
Labels
A-ECSEntities, components, systems, and eventsEntities, components, systems, and eventsC-BugAn unexpected or incorrect behaviorAn unexpected or incorrect behaviorD-StraightforwardSimple bug fixes and API improvements, docs, test and examplesSimple bug fixes and API improvements, docs, test and examplesP-UnsoundA bug that results in undefined compiler behaviorA bug that results in undefined compiler behaviorS-Ready-For-ImplementationThis issue is ready for an implementation PR. Go for it!This issue is ready for an implementation PR. Go for it!
Milestone
Description
Bevy version and features
- main branch after system combinators short circuiting with system failure #20671 was merged
What went wrong
This call to default system handler is unsound:
https://github.com/bevyengine/bevy/pull/20671/changes#diff-0e47efcf16c3678b59327508ac55eb70852f97c045dc1c4033aa57d8d3a34b5eR177
default_system_handler reads the DefaultErrorHandler resource, but SystemCombinator doesn't register read access to that resource.
Potential Fix
- We could register the access in
System::initialize
Metadata
Metadata
Assignees
Labels
A-ECSEntities, components, systems, and eventsEntities, components, systems, and eventsC-BugAn unexpected or incorrect behaviorAn unexpected or incorrect behaviorD-StraightforwardSimple bug fixes and API improvements, docs, test and examplesSimple bug fixes and API improvements, docs, test and examplesP-UnsoundA bug that results in undefined compiler behaviorA bug that results in undefined compiler behaviorS-Ready-For-ImplementationThis issue is ready for an implementation PR. Go for it!This issue is ready for an implementation PR. Go for it!