ComputedNode box model helper functions
#21903
Open
+90
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to `ComputedNode`.
ickshonpe
added
A-UI
kfc35
reviewed
Nov 21, 2025
| out | ||
| } | ||
|
|
||
| /// Returns the node's padding-box in object-centered physical coordinates. |
| let mut out = self.border_box(); | ||
| out.min.x += self.border.left; | ||
| out.max.x -= self.border.right; | ||
| out.min.y += self.border.top; |
There was a problem hiding this comment.
This might be a stupid comment because I am new, but is this supposed to be out.min.y += self.border.bottom (and the next line should be out.max.y -= self.border.top)? Same comment about this belongs in content_box too
From reading Rect, I had the impression visually that Rect.min is the lower left point defined as (min.x, min.y) and Rect.max is the upper right point e.g (max.x, max.y), and that the BorderRect left/right/top/bottom values are units “towards its center.” If that’s the case, should min.y should be affected by border.bottom instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Add helper functions to
ComputedNodethat return the bounds of the node's border, padding, and content areas.Solution
Add helper functions
border_box,padding_box, andcontent_boxtoComputedNode.Included a release note. These changes are very trivial and don't really need one, but I've got quite a few more less trivial changes to
ComputedNodethat I want to add later.Testing
This PR also includes a couple of trivial tests.