Skip to content

Conversation

@ieedan
Copy link
Contributor

@ieedan ieedan commented Dec 11, 2025

Fixes an issue where the border on the last row of the table is doubled.

Summary by CodeRabbit

  • Style
    • Updated table row styling to conditionally display bottom borders only on non-final rows, removing borders from the last row while maintaining row separators throughout the table.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Dec 11, 2025

Walkthrough

The table row styling in the theme configuration was updated to conditionally apply bottom borders only to non-last rows, removing the permanent border from the final table row across both theme and shadcnTheme configurations.

Changes

Cohort / File(s) Change Summary
Table Row Styling
src/lib/theme.ts
Updated tr.base definitions in both theme and shadcnTheme to use conditional not-last:border-b instead of permanent border-b, eliminating the bottom border on the last table row while preserving hover and transition effects

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Single file with straightforward styling adjustments
  • Repetitive pattern change applied consistently across two theme configurations
  • No logic modifications or behavioral changes

Poem

🐰 A table's edge, once thick with line,
Now stops before the final spine,
The last row breathes, unburdened, free—
A cleaner grid for all to see!

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: table styles' directly relates to the main change - fixing the table row border styling issue described in the PR objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
src/lib/theme.ts (2)

87-89: Consider using border-b last:border-b-0 instead of not-last:border-b for broader Tailwind compatibility

The intent (no bottom border on the last row to avoid the double border) is good, but not-last: is non‑standard and may rely on custom Tailwind config. A more conventional pattern is to always set border-b and then clear it on the last row:

-	tr: {
-		base: 'border-gray-200 not-last:border-b hover:bg-gray-100/50 transition-colors'
-	},
+	tr: {
+		base: 'border-b border-gray-200 last:border-b-0 hover:bg-gray-100/50 transition-colors'
+	},

This keeps the visual behavior while avoiding reliance on a custom variant.

Please confirm whether your Tailwind setup explicitly supports the not-last: variant; if not, the above change is safer.


267-269: Mirror the same border-b last:border-b-0 pattern in shadcnTheme.tr.base

For consistency with the primary theme and to avoid depending on not-last: support, you can apply the same conventional Tailwind pattern here:

-	tr: {
-		base: 'border-border not-last:border-b hover:bg-muted/50 transition-colors'
-	},
+	tr: {
+		base: 'border-b border-border last:border-b-0 hover:bg-muted/50 transition-colors'
+	},

Same behavior (no bottom border on the last row) with more standard Tailwind variants.

Please verify this matches your desired table borders in both light/dark modes with your Tailwind config.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 64c2aeb and cd7b8c5.

📒 Files selected for processing (1)
  • src/lib/theme.ts (2 hunks)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant