Ready button fixes 3#203
Merged
Beherith merged 2 commits intobeyond-all-reason:masterfrom Jul 1, 2022
Merged
Conversation
- Fixes "Not Ready" outsizing ready button on default scaling on 1080p displays - Fixes ready button being grey with "Button" caption by default
- Decrease button & font sizes to give ready / start buttons more prominence - Use i18n lib for tooltips - Change tooltip depending on button state - Add `SetButtonStatePlaying()` and `SetButtonStateSpectating()` to avoid duplication of constants throughout the code. - Tooltip/caption values set after button init with `SetButtonStatePlaying()` - Move `button_highlight` style colours to mirror `option_button` colours - Makes use of `suppressButtonReaction` to remove hints that the play/spectating buttons are pressable when they aren't (This won't work until Spring-Chobby/Chobby#547 is merged, due to a typo in the source.)
MasterBel2
force-pushed
the
ready-button-fixes-3
branch
from
98fe220 to
806eb6d
Compare
Contributor
Author
|
Pushed a commit to this branch incorrectly; now removed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes "Not Ready" caption outsizing button area on default scaling on 1080p displays
Fixes ready button being grey with "Button" caption by default
Decrease button & font sizes to give ready / start buttons more prominence
Use i18n lib for tooltips
Change tooltip depending on button state
Add
SetButtonStatePlaying()andSetButtonStateSpectating()to avoid duplication of constants throughout the code.Tooltip/caption values set after button init with
SetButtonStatePlaying()Move
button_highlightstyle colours to mirroroption_buttoncoloursMakes use of
suppressButtonReactionto remove hints that the play/spectating buttons are pressable when they aren't (This won't work until Renameobj.supressButtonReactiontoobj.suppressButtonReactionSpring-Chobby/Chobby#547 is merged, due to a typo in the source.)Some images are below.
Shows new highlighted button style:
Shows new unhighlighted button style, one of the new tooltips, and how the Play button will not highlight on hover when selected:
