Skip to content

Fix t/Artist.t: Van Halen is not unique any more.#15

Open
gregoa wants to merge 1 commit intobfaist:masterfrom
pkg-perl-tools:pkg-perl-1709053727
Open

Fix t/Artist.t: Van Halen is not unique any more.#15
gregoa wants to merge 1 commit intobfaist:masterfrom
pkg-perl-tools:pkg-perl-1709053727

Conversation

@gregoa
Copy link

@gregoa gregoa commented Feb 27, 2024

In Debian we are currently applying the following patch to
WebService-MusicBrainz.
We thought you might be interested in it too.

Description: Fix t/Artist.t: Van Halen is not unique any more.
 t/Artist.t's 6th test fails, as the search for { artist => 'Van Halen', type => 'group' }
 does not return one result, but two:
 .
 #                            'name' => 'Van Halen',
 #                            'disambiguation' => 'American hard rock band',
 .
 #                            'name' => 'JUMP - America\'s Van Halen Experience',
 #                            'disambiguation' => 'Van Halen tribute band'
 Adjust the expected count. And use '>= 1' instead of '== 2' because who knows.
Origin: vendor
Author: gregor herrmann <gregoa@debian.org>
Last-Update: 2024-02-27

The patch is tracked in our Git repository at
https://salsa.debian.org/perl-team/modules/packages/libwebservice-musicbrainz-perl/raw/master/debian/patches/van-halen.patch

Thanks for considering,
gregor herrmann,
Debian Perl Group

bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request Jan 23, 2026
…328814

https://build.opensuse.org/request/show/1328814
by user tinita + anag_factory
- updated to 1.0.10
   see /usr/share/doc/packages/perl-WebService-MusicBrainz/Changes
  1.0.5 Tuesday March 19th 2019
  	- Fix Area.t ext:score -> ns2:score.  See bfaist/webservice-musicbrainz#7 - "Tests: Modifying area code as it fails".  See bfaist/webservice-musicbrainz#8 - "Bug on compiling under Xenial".
  1.0.6 Tuesday July 26th 2022
     - MusicBrainz.pm - Use 'release-group' as key on $search_fields.
     - Request.pm - Updated url_base from http to https.
  1.0.7 Monday July 24th 2024
  	- Artist.t - Account for searching on a artist/group can return one or more results.  In this case, searching on "Van Halen" returns all the Van Halen tribute bands.  See bfaist/webservice-musicbrainz#15 - "Fix t/Artist.t: V
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant