xMath3_WIP #410
Merged
xMath3_WIP #410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and StatforNPC. Also have outline for ClearActive in comments.
…d en_SM_NOTICES to zNPCTypeCommon to avoid recursive include.
…Spawner instead of transitively via zNPCTypeCommon.
…r to import into xMath3.
…y are defined there.
…3x3Identity because they were already specified in xClimate.cpp. Added declarations for them in xClimate.h and moved an import in zNPCGlyp.cpp.
SquareMan
reviewed
Feb 20, 2025
…3Copy will eventually be moved to xMath3 most likely.
…cpp. For other uses in game, use from xMath3, hence uncommenting.
SquareMan
requested changes
Feb 20, 2025
src/SB/Core/x/xMath3.h
Outdated
| void xBoxFromLine(xBox& box, const xLine3& line); | ||
| void xBoxFromRay(xBox& box, const xRay3& ray); | ||
| void xMat3x3Identity(xMat3x3* matrix); | ||
| void xMat3x3Identity(xMat3x3* matrix); // May come from xClimate |
Member
There was a problem hiding this comment.
A bit of a nit I know, but can you remove these comments (or at least reword them somehow). They don't really "come from" xClimate, but rather would have been defined here directly in this header file and just by chance the definition in xClimate's translation unit ended up being the one that the linker chose to use (maybe it was the first/last usage or something like that).
Member
There was a problem hiding this comment.
If you want to leave a comment about this I would probably say something like
// TODO: These functions should be inline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Groundwork for xMath3.