Start of bink sdk #670
Merged
Start of bink sdk #670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
| Section | From | To | Bytes | |
|---|---|---|---|---|
| 📈 | .text |
84.88% | 98.11% | +430 |
| Function | From | To | Bytes | |
|---|---|---|---|---|
| 📈 | xFuncPiece_Eval(xFuncPiece*, float, xFuncPiece**) |
0.00% | 81.64% | +189 |
| 📈 | xFuncPiece_ShiftPiece(xFuncPiece*, xFuncPiece*, float) |
0.00% | 95.52% | +240 |
main/SB/Core/x/xMath3
| Section | From | To | Bytes | |
|---|---|---|---|---|
| 📈 | .text |
68.46% | 91.73% | +1704 |
| Function | From | To | Bytes | |
|---|---|---|---|---|
| 📈 | xMath3Init() |
0.00% | 99.80% | +163 |
| 📈 | xLine3VecDist2(const xVec3*, const xVec3*, const xVec3*, xIsect*) |
0.00% | 89.21% | +235 |
| ✅ | xBoxInitBoundOBB(xBox*, const xBox*, const xMat4x3*) |
0.00% | 100.00% | +424 |
| ✅ | xBoxInitBoundCapsule(xBox*, const xCapsule*) |
0.00% | 100.00% | +184 |
| ✅ | xBoxFromCone(xBox&, const xVec3&, const xVec3&, float, float, float) |
0.00% | 100.00% | +164 |
| ✅ | xQuatFromMat(xQuat*, const xMat3x3*) |
30.09% | 100.00% | +341 |
| ✅ | xQuatNormalize(xQuat*, const xQuat*) |
0.00% | 100.00% | +192 |
main/SB/Core/x/xMorph
| Section | From | To | Bytes |
|---|
| Function | From | To | Bytes |
|---|
main/SB/Core/x/xordarray
| Section | From | To | Bytes | |
|---|---|---|---|---|
| ✅ | .sdata2 |
93.75% | 100.00% | +1 |
| ✅ | .text |
66.14% | 100.00% | +384 |
| Function | From | To | Bytes | |
|---|---|---|---|---|
| ✅ | XOrdInsert(st_XORDEREDARRAY*, void*, int (*)(void*, void*)) |
26.11% | 100.00% | +133 |
| ✅ | XOrdLookup(st_XORDEREDARRAY*, const void*, int (*)(const void*, void*)) |
68.11% | 100.00% | +48 |
| ✅ | XOrdSort(st_XORDEREDARRAY*, int (*)(void*, void*)) |
10.88% | 100.00% | +203 |
main/SB/Core/x/xQuickCull
| Section | From | To | Bytes | |
|---|---|---|---|---|
| ✅ | .sdata2 |
88.89% | 100.00% | +2 |
| 📈 | .text |
22.72% | 99.59% | +1516 |
| Function | From | To | Bytes | |
|---|---|---|---|---|
| ✅ | xQuickCullForBound(xQCControl*, xQCData*, const xBound*) |
0.00% | 100.00% | +92 |
| ✅ | xQuickCullCellForVec(xQCControl*, xQCData*, const xVec3*) |
0.00% | 100.00% | +304 |
| ✅ | xQuickCullCellMerge(xQCData*, const xQCData*, const xQCData*) |
0.00% | 100.00% | +212 |
| ✅ | xQuickCullForLine(xQCControl*, xQCData*, const xLine3*) |
0.00% | 100.00% | +104 |
| ✅ | xQuickCullForRay(xQCControl*, xQCData*, const xRay3*) |
0.00% | 100.00% | +368 |
| ✅ | xQuickCullForSphere(xQCControl*, xQCData*, const xSphere*) |
0.00% | 100.00% | +200 |
| ✅ | xQuickCullForBox(xQCControl*, xQCData*, const xBox*) |
0.00% | 100.00% | +108 |
| ✅ | xQuickCullForOBB(xQCControl*, xQCData*, const xBox*, const xMat4x3*) |
0.00% | 100.00% | +84 |
| ✅ | xQuickCullForEverything(xQCData*) |
0.00% | 100.00% | +44 |
main/SB/Core/gc/iFMV
| Section | From | To | Bytes | |
|---|---|---|---|---|
| ️ |
.text |
96.67% | 96.42% | --8 |
| Function | From | To | Bytes | |
|---|---|---|---|---|
| ️ |
PlayFMV(char*, unsigned long, float) |
94.95% | 93.95% | --8 |
main/bink/src/sdk/decode/ngc/binkngc
| Section | From | To | Bytes | |
|---|---|---|---|---|
| 📈 | .sdata |
0.00% | 50.00% | +12 |
| 📈 | .text |
0.00% | 6.94% | +88 |
| Function | From | To | Bytes | |
|---|---|---|---|---|
| ✅ | radfree |
0.00% | 100.00% | +88 |
main/bink/src/sdk/decode/binkread
| Section | From | To | Bytes | |
|---|---|---|---|---|
| ✅ | .bss |
0.00% | 100.00% | +256 |
| 📈 | .data |
0.00% | 99.89% | +14875 |
| ✅ | .sbss |
0.00% | 100.00% | +4 |
| ✅ | .sdata |
0.00% | 100.00% | +40 |
| 📈 | .text |
0.00% | 7.87% | +1316 |
| Function | From | To | Bytes | |
|---|---|---|---|---|
| 📈 | bpopmalloc |
0.00% | 92.22% | +66 |
| ✅ | BinkSetError |
0.00% | 100.00% | +44 |
| ✅ | BinkGetError |
0.00% | 100.00% | +12 |
| 📈 | BinkSetSoundSystem |
0.00% | 59.56% | +81 |
| 📈 | conv16to8 |
0.00% | 10.00% | +4 |
| 📈 | checksound |
0.00% | 0.58% | +3 |
| ✅ | inittimer |
0.00% | 100.00% | +72 |
| ✅ | GotoFrame |
0.00% | 100.00% | +276 |
| ✅ | BinkSetFrameRate |
0.00% | 100.00% | +12 |
| ✅ | BinkSetIOSize |
0.00% | 100.00% | +8 |
| ✅ | BinkSetIO |
0.00% | 100.00% | +8 |
| ✅ | BinkSetSimulate |
0.00% | 100.00% | +8 |
| 📈 | BinkSetSoundTrack |
0.00% | 69.71% | +47 |
| ✅ | bink_suspend_io |
0.00% | 100.00% | +40 |
| ✅ | bink_try_suspend_io |
0.00% | 100.00% | +40 |
| ✅ | bink_resume_io |
0.00% | 100.00% | +40 |
| ✅ | bink_idle_on_io |
0.00% | 100.00% | +32 |
| ✅ | bink_get_priority_sound |
0.00% | 100.00% | +28 |
| 📈 | bink_sound_callback |
0.00% | 84.12% | +57 |
| 📈 | BinkOpen |
0.00% | 0.10% | +4 |
| ✅ | BinkCopyToBuffer |
0.00% | 100.00% | +64 |
| 📈 | BinkCopyToBufferRect |
0.00% | 0.23% | +4 |
| 📈 | BinkDoFrame |
0.00% | 0.27% | +4 |
| ✅ | timeframe |
0.00% | 100.00% | +44 |
| 📈 | BinkNextFrame |
0.00% | 0.97% | +4 |
| 📈 | BinkGetKeyFrame |
0.00% | 1.15% | +4 |
| 📈 | BinkGoto |
0.00% | 0.71% | +4 |
| 📈 | BinkClose |
0.00% | 1.01% | +3 |
| 📈 | endframe |
0.00% | 4.35% | +4 |
| 📈 | BinkWait |
0.00% | 0.90% | +4 |
| 📈 | BinkPause |
0.00% | 1.79% | +3 |
| 📈 | BinkGetSummary |
0.00% | 0.92% | +3 |
| 📈 | BinkGetRealtime |
0.00% | 1.03% | +3 |
| 📈 | BinkGetRects |
0.00% | 0.40% | +4 |
| ✅ | BinkService |
0.00% | 100.00% | +44 |
| 📈 | idtoindex |
0.00% | 5.00% | +4 |
| 📈 | BinkSetVolume |
0.00% | 3.57% | +3 |
| 📈 | BinkSetMixBins |
0.00% | 3.33% | +3 |
| 📈 | BinkSetMixBinVolumes |
0.00% | 3.12% | +4 |
| 📈 | BinkSetPan |
0.00% | 3.57% | +3 |
| ✅ | BinkLogoAddress |
0.00% | 100.00% | +12 |
| ✅ | BinkGetTrackType |
0.00% | 100.00% | +32 |
| ✅ | BinkGetTrackMaxSize |
0.00% | 100.00% | +32 |
| ✅ | BinkGetTrackID |
0.00% | 100.00% | +32 |
| 📈 | BinkOpenTrack |
0.00% | 1.25% | +4 |
| 📈 | BinkCloseTrack |
0.00% | 94.74% | +72 |
| 📈 | BinkGetTrackData |
0.00% | 1.15% | +4 |
| ✅ | BinkSetVideoOnOff |
0.00% | 100.00% | +20 |
| 📈 | BinkSetSoundOnOff |
0.00% | 1.20% | +4 |
main/bink/shared/time/radcb
| Section | From | To | Bytes | |
|---|---|---|---|---|
| 📈 | .text |
0.00% | 23.80% | +419 |
| Function | From | To | Bytes | |
|---|---|---|---|---|
| 📈 | RADCB_unregister_2_callbacks |
0.00% | 4.76% | +4 |
| ✅ | RADCB_registered_count |
0.00% | 100.00% | +8 |
| 📈 | RADCB_try_to_suspend_handler |
0.00% | 3.57% | +3 |
| ✅ | RADCB_suspend_handler |
0.00% | 100.00% | +64 |
| 📈 | RADCB_resume_handler |
0.00% | 99.86% | +83 |
| 📈 | RADCB_try_to_suspend_callback |
0.00% | 2.70% | +4 |
| 📈 | RADCB_suspend_callback |
0.00% | 3.70% | +4 |
| ✅ | RADCB_suspend_2_callbacks |
0.00% | 100.00% | +60 |
| 📈 | RADCB_resume_callback |
0.00% | 3.33% | +3 |
| ✅ | RADCB_suspend_2_handlers |
0.00% | 100.00% | +52 |
| ✅ | RADCB_free_handler |
0.00% | 100.00% | +68 |
| ✅ | RADCB_free_2_handlers |
0.00% | 100.00% | +52 |
| ✅ | RADCB_idle_on_callbacks |
0.00% | 100.00% | +4 |
| ✅ | RADCB_callback_size |
0.00% | 100.00% | +8 |
main/bink/src/sdk/decode/expand
| Section | From | To | Bytes | |
|---|---|---|---|---|
| ✅ | .rodata |
0.00% | 100.00% | +1184 |
| Function | From | To | Bytes |
|---|
main/bink/src/sdk/popmal
| Section | From | To | Bytes | |
|---|---|---|---|---|
| 📈 | .sdata |
20.00% | 80.00% | +14 |
| 📈 | .text |
1.96% | 3.92% | +8 |
| Function | From | To | Bytes | |
|---|---|---|---|---|
| 📈 | pushmalloc |
0.00% | 1.61% | +4 |
| 📈 | popmalloc |
0.00% | 2.63% | +4 |
JoshSanch
approved these changes
Nov 28, 2025
Collaborator
JoshSanch
left a comment
JoshSanch
left a comment
There was a problem hiding this comment.
Super glad to see this work done, and some additionally linked files to boot. Only one comment now that things are working and building ok.
| "Wii/1.5": "mwcc_43_188", | ||
| "Wii/1.6": "mwcc_43_202", | ||
| "Wii/1.7": "mwcc_43_213", | ||
| "ProDG/3.5": "mwcc_43_213", |
Collaborator
There was a problem hiding this comment.
Is this a leftover testing configuration? Not sure why this change is here
Contributor
Author
There was a problem hiding this comment.
ProDG does not have a compiler mapping. So i reused the wii mapping with the prodg compiler, This allows us to create scratches for the ProDG side of the repo. The only caveat being that you have to change the compiler version on each scratch you make to ProDG 3.5
Collaborator
There was a problem hiding this comment.
Can we not add a ProDG mapping rather than removing the correct Wii mapping? Not sure what the technical limitations are here if you could clarify.
Contributor
Author
There was a problem hiding this comment.
The "mwcc_xx" is the mapping for decomp.me, saying which compiler to use for a scratch. Each mapping you see here are the only ones., and there isn't one for ProgDG. When the compiler maps get updated for the site, we can change this over. This is just a temporary work around since this is out of our hands.
Collaborator
There was a problem hiding this comment.
Alright - can you make a request to Encounter for a ProdDG mapping and tag me on it? Once that's done I will merge this
Collaborator
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.