xMath3 Cleanup #694
Merged
xMath3 Cleanup #694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| Section | From | To | Bytes | |
|---|---|---|---|---|
| 📈 | .text |
91.73% | 94.17% | +178 |
| Function | From | To | Bytes | |
|---|---|---|---|---|
| 📈 | xBoxFromCircle(xBox&, const xVec3&, const xVec3&, float) |
0.00% | 55.62% | +142 |
| ✅ | xQuatLength2(const xQuat*) |
0.00% | 100.00% | +36 |
JoshSanch
requested changes
Dec 3, 2025
src/SB/Core/x/xMath3.cpp
Outdated
| void xMat3x3Normalize(xMat3x3* o, const xMat3x3* m) | ||
| { | ||
| xMat4x3 temp; | ||
| xVec3Normalize((xVec3*)o, (xVec3*)m); |
Collaborator
There was a problem hiding this comment.
Suggested change
| xVec3Normalize((xVec3*)o, (xVec3*)m); | |
| xVec3Normalize(&o->right, &m->right); |
src/SB/Core/x/xMath3.cpp
Outdated
| m->at.z = 0.0f; | ||
| return temp_f31; | ||
| } | ||
| if (((F32)__fabs(at->z) < 0.00001f) && ((F32)__fabs(at->x) < 0.00001f)) |
Collaborator
There was a problem hiding this comment.
Check out the FABS macro for this one
|
| Section | From | To | Bytes | |
|---|---|---|---|---|
| 📈 | .text |
91.73% | 94.17% | +178 |
| Function | From | To | Bytes | |
|---|---|---|---|---|
| 📈 | xBoxFromCircle(xBox&, const xVec3&, const xVec3&, float) |
0.00% | 55.62% | +142 |
| ✅ | xQuatLength2(const xQuat*) |
0.00% | 100.00% | +36 |
JoshSanch
approved these changes
Dec 3, 2025
Collaborator
JoshSanch
left a comment
JoshSanch
left a comment
There was a problem hiding this comment.
Always glad to see cleanup PRs, especially now that we're getting closer to project completion. Modders will thank you for your service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arranged functions in both header and cpp in objdiff order. Some cleanup. Also implemented last two function that needed it. Plan to do more cleanup but this file gets touched a lot and thought I'd kick up what I had.