Skip to content

Conversation

@bluisblu
Copy link
Contributor

xUtilStartup seems to just directly contain the code of xUtil_crc_init in place of actually calling it, only r4 and r5 need to be swapped

@github-actions
Copy link

⚠️ 🔥

+233 bytes
🆗 Bot Rating: A fair and commendable contribution

Regressions: 2

⚠️ main/SB/Core/x/xWad3 - .text -316 bytes -> 35.71%
⚠️ main/SB/Core/x/xWad1 - .text -8 bytes -> 0.00%

Progress: 8

📈 main/SB/Core/x/xWad5 - .text +12 bytes -> 6.37%
📈 main/SB/Core/x/xWad5 - .text +224 bytes -> 29.39%
📈 main/SB/Core/gc/iWad - .text +604 bytes -> 70.56%
📈 main/SB/Core/x/xWad5 - xUtilStartup() +216 bytes -> 88.52%
main/SB/Core/x/xWad5 - xStrHash(const char*, unsigned long) +3 bytes -> 100.00%
main/SB/Core/x/xWad5 - xStrHash(const char*) +3 bytes -> 100.00%
main/SB/Core/x/xWad5 - xStrHashCat(unsigned int, const char*) +3 bytes -> 100.00%
main/SB/Core/x/xWad5 - xUtilShutdown() +8 bytes -> 100.00%

@github-actions
Copy link

⚠️ 🔥

+233 bytes
🆗 Bot Rating: A fair and commendable contribution

Regressions: 2

⚠️ main/SB/Core/x/xWad3 - .text -316 bytes -> 35.71%
⚠️ main/SB/Core/x/xWad1 - .text -8 bytes -> 0.00%

Progress: 8

📈 main/SB/Core/x/xWad5 - .text +12 bytes -> 6.37%
📈 main/SB/Core/x/xWad5 - .text +224 bytes -> 29.39%
📈 main/SB/Core/gc/iWad - .text +604 bytes -> 70.56%
📈 main/SB/Core/x/xWad5 - xUtilStartup() +216 bytes -> 88.52%
main/SB/Core/x/xWad5 - xStrHash(const char*, unsigned long) +3 bytes -> 100.00%
main/SB/Core/x/xWad5 - xStrHash(const char*) +3 bytes -> 100.00%
main/SB/Core/x/xWad5 - xStrHashCat(unsigned int, const char*) +3 bytes -> 100.00%
main/SB/Core/x/xWad5 - xUtilShutdown() +8 bytes -> 100.00%

For real this time
@github-actions
Copy link

⚠️ 🔥

+233 bytes
🆗 Bot Rating: A fair and commendable contribution

Regressions: 2

⚠️ main/SB/Core/x/xWad3 - .text -316 bytes -> 35.71%
⚠️ main/SB/Core/x/xWad1 - .text -8 bytes -> 0.00%

Progress: 8

📈 main/SB/Core/x/xWad5 - .text +12 bytes -> 6.37%
📈 main/SB/Core/x/xWad5 - .text +224 bytes -> 29.39%
📈 main/SB/Core/gc/iWad - .text +604 bytes -> 70.56%
📈 main/SB/Core/x/xWad5 - xUtilStartup() +216 bytes -> 88.52%
main/SB/Core/x/xWad5 - xStrHash(const char*, unsigned long) +3 bytes -> 100.00%
main/SB/Core/x/xWad5 - xStrHash(const char*) +3 bytes -> 100.00%
main/SB/Core/x/xWad5 - xStrHashCat(unsigned int, const char*) +3 bytes -> 100.00%
main/SB/Core/x/xWad5 - xUtilShutdown() +8 bytes -> 100.00%

@github-actions
Copy link

⚠️ 🔥

+305 bytes
🆗 Bot Rating: A decent contribution. Thank you!

Regressions: 2

⚠️ main/SB/Core/x/xWad3 - .text -316 bytes -> 35.71%
⚠️ main/SB/Core/x/xWad1 - .text -8 bytes -> 0.00%

Progress: 9

📈 main/SB/Core/x/xWad5 - .text +83 bytes -> 8.16%
📈 main/SB/Core/x/xWad5 - .text +224 bytes -> 29.39%
📈 main/SB/Core/gc/iWad - .text +604 bytes -> 70.56%
📈 main/SB/Core/x/xWad5 - xUtilStartup() +216 bytes -> 88.52%
main/SB/Core/x/xWad5 - xStrHash(const char*, unsigned long) +3 bytes -> 100.00%
main/SB/Core/x/xWad5 - imemcmp(const void*, const void*, unsigned long) +72 bytes -> 100.00%
main/SB/Core/x/xWad5 - xStrHash(const char*) +3 bytes -> 100.00%
main/SB/Core/x/xWad5 - xStrHashCat(unsigned int, const char*) +3 bytes -> 100.00%
main/SB/Core/x/xWad5 - xUtilShutdown() +8 bytes -> 100.00%

Copy link
Collaborator

@LivewireCB LivewireCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Good work.

@LivewireCB LivewireCB merged commit c14e37a into bfbbdecomp:main Jul 20, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants