xPad and xRender work #25

bluisblu · 2025-07-22T19:33:27Z

Also clang-formatted files that I touched previously

github-actions · 2025-07-22T19:34:22Z

⚠️ 🔥

+2632 bytes
🆗 Bot Rating: Amazing contribution, you are the decomp GOAT 🐐

Regressions: 12

⚠️ main/SB/Core/x/xWad4 - .sbss -3 bytes -> 46.32%
⚠️ main/SB/Core/x/xWad4 - .text -743 bytes -> 51.20%
⚠️ main/SB/Core/x/xWad4 - .text -38 bytes -> 35.79%
⚠️ main/SB/Core/x/xWad3 - .text -316 bytes -> 35.71%
⚠️ main/SB/Core/x/xWad1 - .text -8 bytes -> 0.00%
⚠️ main/SB/Core/x/xWad4 - xSG_cb_leader_load(void*, st_XSAVEGAME_DATA*, st_XSAVEGAME_READCONTEXT*, unsigned int, int) -146 bytes -> 26.89%
⚠️ main/SB/Core/x/xWad4 - xSG_cb_leader_svproc(void*, st_XSAVEGAME_DATA*, st_XSAVEGAME_WRITECONTEXT*) -178 bytes -> 26.39%
⚠️ main/SB/Core/x/xWad4 - xSGProcess(st_XSAVEGAME_DATA*) -188 bytes -> 0.00%
⚠️ main/SB/Core/x/xWad4 - xSGSetup(st_XSAVEGAME_DATA*, int, char*, int, long long, int) -159 bytes -> 0.00%
⚠️ main/SB/Core/x/xWad4 - xSGSetup(st_XSAVEGAME_DATA*) -46 bytes -> 2.70%
⚠️ main/SB/Core/x/xWad4 - xSGInit(en_SAVEGAME_MODE) -111 bytes -> 55.56%
⚠️ main/SB/Core/x/xWad4 - PKR_ReadInit(void*, const char*, unsigned int, int*, PKRAssetType*, int) -214 bytes -> 14.43%

Progress: 34

📈 main/SB/Core/x/xWad4 - .text +707 bytes -> 17.00%
📈 main/SB/Core/x/xWad4 - .text +1180 bytes -> 49.54%
📈 main/SB/Core/gc/iWad - .text +11 bytes -> 5.72%
📈 main/SB/Core/x/xWad4 - .text +108 bytes -> 26.43%
📈 main/SB/Core/gc/iWad - .text +604 bytes -> 70.56%
✅ main/SB/Core/x/xWad4 - .text +244 bytes -> 100.00%
📈 main/SB/Core/x/xWad4 - .sdata2 +59 bytes -> 39.00%
✅ main/SB/Core/x/xWad4 - .text +64 bytes -> 100.00%
📈 main/SB/Core/x/xWad4 - xPadUpdate(int, float) +615 bytes -> 45.97%
📈 main/SB/Core/x/xWad4 - PKR_parse_TOC(st_HIPLOADDATA*, st_PACKER_READ_DATA*) +3 bytes -> 17.67%
📈 main/SB/Core/x/xWad4 - xPadNormalizeAnalog(_tagxPad&, int, int) +440 bytes -> 48.89%
📈 main/SB/Core/x/xWad4 - xParGroupAddPar(xParGroup*) +67 bytes -> 39.11%
✅ main/SB/Core/x/xWad4 - xParCmdInit() +684 bytes -> 100.00%
📈 main/SB/Core/x/xWad4 - xParGroupAnimate(xParGroup*, float) +40 bytes -> 6.29%
📈 main/SB/Core/x/xWad4 - xParCmdRotateAround_Update(xParCmd*, xParGroup*, float) +24 bytes -> 8.89%
📈 main/SB/Core/x/xWad4 - xSGGameIsEmpty(st_XSAVEGAME_DATA*, int) +47 bytes -> 31.03%
📈 main/SB/Core/x/xWad4 - PKRStartup() +172 bytes -> 94.74%
📈 main/SB/Core/x/xWad4 - XSGAutoData::SetCache(int, int, int) +36 bytes -> 86.00%
📈 main/SB/Core/x/xWad4 - xPadEnable(int) +24 bytes -> 27.27%
📈 main/SB/Core/gc/iWad - iPadEnable(_tagxPad*, short) +4 bytes -> 22.86%
✅ main/SB/Core/x/xWad4 - xRenderStateSetAlphaDiscard(int) +124 bytes -> 100.00%
📈 main/SB/Core/gc/iWad - iPadStopRumble() +3 bytes -> 37.04%
📈 main/SB/Core/gc/iWad - iPadStopRumble(_tagxPad*) +4 bytes -> 36.00%
✅ main/SB/Core/x/xWad4 - xRenderStateResetAlphaDiscard() +96 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xPadRumbleEnable(int, int) +63 bytes -> 100.00%
📈 main/SB/Core/x/xWad4 - xSG_cb_ISGChange(void*, en_CHGCODE) +3 bytes -> 5.26%
✅ main/SB/Core/x/xWad4 - xRenderBufferInit() +64 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xPadInit() +36 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xRenderFixIMEnd() +4 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xRenderFixIMBegin() +4 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xRenderFixUntexturedEnd(RpAtomic*) +4 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xRenderFixUntexturedBegin(RpAtomic*) +4 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xRenderSceneExit() +4 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xRenderSceneEnter() +4 bytes -> 100.00%

Causes a ton of regressions, gonna need to split xPadNormalizeAnalog off into another file to make `isinf` inline

github-actions · 2025-07-22T19:54:28Z

⚠️ 🔥

+1364 bytes
🆗 Bot Rating: A fantastic contribution! ✨🎉

Regressions: 3

⚠️ main/SB/Core/x/xWad4 - .sbss -3 bytes -> 46.32%
⚠️ main/SB/Core/x/xWad3 - .text -316 bytes -> 35.71%
⚠️ main/SB/Core/x/xWad1 - .text -8 bytes -> 0.00%

Progress: 23

📈 main/SB/Core/x/xWad4 - .text +988 bytes -> 42.15%
📈 main/SB/Core/gc/iWad - .text +11 bytes -> 5.72%
📈 main/SB/Core/gc/iWad - .text +604 bytes -> 70.56%
✅ main/SB/Core/x/xWad4 - .text +244 bytes -> 100.00%
📈 main/SB/Core/x/xWad4 - .sdata2 +59 bytes -> 39.00%
✅ main/SB/Core/x/xWad4 - .text +64 bytes -> 100.00%
📈 main/SB/Core/x/xWad4 - xPadUpdate(int, float) +615 bytes -> 45.97%
📈 main/SB/Core/x/xWad4 - xPadNormalizeAnalog(_tagxPad&, int, int) +248 bytes -> 27.56%
📈 main/SB/Core/x/xWad4 - xPadEnable(int) +24 bytes -> 27.27%
📈 main/SB/Core/gc/iWad - iPadEnable(_tagxPad*, short) +4 bytes -> 22.86%
✅ main/SB/Core/x/xWad4 - xRenderStateSetAlphaDiscard(int) +124 bytes -> 100.00%
📈 main/SB/Core/gc/iWad - iPadStopRumble() +3 bytes -> 37.04%
📈 main/SB/Core/gc/iWad - iPadStopRumble(_tagxPad*) +4 bytes -> 36.00%
✅ main/SB/Core/x/xWad4 - xRenderStateResetAlphaDiscard() +96 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xPadRumbleEnable(int, int) +63 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xRenderBufferInit() +64 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xPadInit() +36 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xRenderFixIMEnd() +4 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xRenderFixIMBegin() +4 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xRenderFixUntexturedEnd(RpAtomic*) +4 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xRenderFixUntexturedBegin(RpAtomic*) +4 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xRenderSceneExit() +4 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xRenderSceneEnter() +4 bytes -> 100.00%

github-actions · 2025-07-25T03:17:39Z

⚠️ 🔥

+1804 bytes
🆗 Bot Rating: A fantastic contribution! ✨🎉

Regressions: 3

⚠️ main/SB/Core/x/xWad4 - .sbss -3 bytes -> 46.32%
⚠️ main/SB/Core/x/xWad3 - .text -316 bytes -> 35.71%
⚠️ main/SB/Core/x/xWad1 - .text -8 bytes -> 0.00%

Progress: 27

📈 main/SB/Core/gc/iScrFX - .text +440 bytes -> 14.96%
📈 main/SB/Core/x/xWad4 - .text +988 bytes -> 42.15%
📈 main/SB/Core/gc/iWad - .text +11 bytes -> 5.72%
📈 main/SB/Core/gc/iWad - .text +604 bytes -> 70.56%
✅ main/SB/Core/x/xWad4 - .text +244 bytes -> 100.00%
📈 main/SB/Core/x/xWad4 - .sdata2 +59 bytes -> 39.00%
✅ main/SB/Core/x/xWad4 - .text +64 bytes -> 100.00%
📈 main/SB/Core/x/xWad4 - xPadUpdate(int, float) +615 bytes -> 45.97%
📈 main/SB/Core/x/xWad4 - xPadNormalizeAnalog(_tagxPad&, int, int) +248 bytes -> 27.56%
📈 main/SB/Core/gc/iScrFX - RenderRect(RwRect*, float) +4 bytes -> 0.89%
✅ main/SB/Core/gc/iScrFX - iScrFxBegin() +240 bytes -> 100.00%
✅ main/SB/Core/gc/iScrFX - iScrFxEnd() +196 bytes -> 100.00%
📈 main/SB/Core/x/xWad4 - xPadEnable(int) +24 bytes -> 27.27%
📈 main/SB/Core/gc/iWad - iPadEnable(_tagxPad*, short) +4 bytes -> 22.86%
✅ main/SB/Core/x/xWad4 - xRenderStateSetAlphaDiscard(int) +124 bytes -> 100.00%
📈 main/SB/Core/gc/iWad - iPadStopRumble() +3 bytes -> 37.04%
📈 main/SB/Core/gc/iWad - iPadStopRumble(_tagxPad*) +4 bytes -> 36.00%
✅ main/SB/Core/x/xWad4 - xRenderStateResetAlphaDiscard() +96 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xPadRumbleEnable(int, int) +63 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xRenderBufferInit() +64 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xPadInit() +36 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xRenderFixIMEnd() +4 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xRenderFixIMBegin() +4 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xRenderFixUntexturedEnd(RpAtomic*) +4 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xRenderFixUntexturedBegin(RpAtomic*) +4 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xRenderSceneExit() +4 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xRenderSceneEnter() +4 bytes -> 100.00%

github-actions · 2025-08-07T05:58:13Z

⚠️ 🔥

+2195 bytes
🆗 Bot Rating: Amazing contribution, you are the decomp GOAT 🐐

Regressions: 3

⚠️ main/SB/Core/x/xWad4 - .sbss -3 bytes -> 46.32%
⚠️ main/SB/Core/x/xWad3 - .text -316 bytes -> 35.71%
⚠️ main/SB/Core/x/xWad1 - .text -8 bytes -> 0.00%

Progress: 28

📈 main/SB/Core/gc/iScrFX - .text +832 bytes -> 25.66%
📈 main/SB/Core/x/xWad4 - .text +988 bytes -> 42.15%
📈 main/SB/Core/gc/iWad - .text +11 bytes -> 5.72%
📈 main/SB/Core/gc/iWad - .text +604 bytes -> 70.56%
✅ main/SB/Core/x/xWad4 - .text +244 bytes -> 100.00%
📈 main/SB/Core/x/xWad4 - .sdata2 +59 bytes -> 39.00%
✅ main/SB/Core/x/xWad4 - .text +64 bytes -> 100.00%
📈 main/SB/Core/x/xWad4 - xPadUpdate(int, float) +615 bytes -> 45.97%
📈 main/SB/Core/x/xWad4 - xPadNormalizeAnalog(_tagxPad&, int, int) +248 bytes -> 27.56%
📈 main/SB/Core/gc/iScrFX - iScrFxCameraEndScene(RwCamera*) +391 bytes -> 67.35%
📈 main/SB/Core/gc/iScrFX - RenderRect(RwRect*, float) +4 bytes -> 0.89%
✅ main/SB/Core/gc/iScrFX - iScrFxBegin() +240 bytes -> 100.00%
✅ main/SB/Core/gc/iScrFX - iScrFxEnd() +196 bytes -> 100.00%
📈 main/SB/Core/x/xWad4 - xPadEnable(int) +24 bytes -> 27.27%
📈 main/SB/Core/gc/iWad - iPadEnable(_tagxPad*, short) +4 bytes -> 22.86%
✅ main/SB/Core/x/xWad4 - xRenderStateSetAlphaDiscard(int) +124 bytes -> 100.00%
📈 main/SB/Core/gc/iWad - iPadStopRumble() +3 bytes -> 37.04%
📈 main/SB/Core/gc/iWad - iPadStopRumble(_tagxPad*) +4 bytes -> 36.00%
✅ main/SB/Core/x/xWad4 - xRenderStateResetAlphaDiscard() +96 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xPadRumbleEnable(int, int) +63 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xRenderBufferInit() +64 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xPadInit() +36 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xRenderFixIMEnd() +4 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xRenderFixIMBegin() +4 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xRenderFixUntexturedEnd(RpAtomic*) +4 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xRenderFixUntexturedBegin(RpAtomic*) +4 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xRenderSceneExit() +4 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xRenderSceneEnter() +4 bytes -> 100.00%

github-actions · 2025-08-07T10:41:56Z

⚠️ 🔥

+2195 bytes
🆗 Bot Rating: Amazing contribution, you are the decomp GOAT 🐐

Regressions: 3

⚠️ main/SB/Core/x/xWad4 - .sbss -3 bytes -> 46.32%
⚠️ main/SB/Core/x/xWad3 - .text -316 bytes -> 35.71%
⚠️ main/SB/Core/x/xWad1 - .text -8 bytes -> 0.00%

Progress: 28

📈 main/SB/Core/gc/iScrFX - .text +832 bytes -> 25.66%
📈 main/SB/Core/x/xWad4 - .text +988 bytes -> 42.15%
📈 main/SB/Core/gc/iWad - .text +11 bytes -> 5.72%
📈 main/SB/Core/gc/iWad - .text +604 bytes -> 70.56%
✅ main/SB/Core/x/xWad4 - .text +244 bytes -> 100.00%
📈 main/SB/Core/x/xWad4 - .sdata2 +59 bytes -> 39.00%
✅ main/SB/Core/x/xWad4 - .text +64 bytes -> 100.00%
📈 main/SB/Core/x/xWad4 - xPadUpdate(int, float) +615 bytes -> 45.97%
📈 main/SB/Core/x/xWad4 - xPadNormalizeAnalog(_tagxPad&, int, int) +248 bytes -> 27.56%
📈 main/SB/Core/gc/iScrFX - iScrFxCameraEndScene(RwCamera*) +391 bytes -> 67.35%
📈 main/SB/Core/gc/iScrFX - RenderRect(RwRect*, float) +4 bytes -> 0.89%
✅ main/SB/Core/gc/iScrFX - iScrFxBegin() +240 bytes -> 100.00%
✅ main/SB/Core/gc/iScrFX - iScrFxEnd() +196 bytes -> 100.00%
📈 main/SB/Core/x/xWad4 - xPadEnable(int) +24 bytes -> 27.27%
📈 main/SB/Core/gc/iWad - iPadEnable(_tagxPad*, short) +4 bytes -> 22.86%
✅ main/SB/Core/x/xWad4 - xRenderStateSetAlphaDiscard(int) +124 bytes -> 100.00%
📈 main/SB/Core/gc/iWad - iPadStopRumble() +3 bytes -> 37.04%
📈 main/SB/Core/gc/iWad - iPadStopRumble(_tagxPad*) +4 bytes -> 36.00%
✅ main/SB/Core/x/xWad4 - xRenderStateResetAlphaDiscard() +96 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xPadRumbleEnable(int, int) +63 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xRenderBufferInit() +64 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xPadInit() +36 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xRenderFixIMEnd() +4 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xRenderFixIMBegin() +4 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xRenderFixUntexturedEnd(RpAtomic*) +4 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xRenderFixUntexturedBegin(RpAtomic*) +4 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xRenderSceneExit() +4 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xRenderSceneEnter() +4 bytes -> 100.00%

LivewireCB

Overall, The pr looks great. We've already discussed the removal of tagxrumble in the discord.

bluisblu added 8 commits July 20, 2025 01:01

Make imemcmp use size_t

57fd22e

xWad4/xPad work

787e4dd

Enable inline for xWad4 and get xPadNormalizeAnalog to 80%

00efcc0

xPadUpdate work

30b525f

xPadUpdate 67%

daab4d1

A bunch of small xRender matches

019f21e

clang-format

5229235

Match all xRender functions in xWad4

4eba25f

Disable inline for xWad4

0dbdcba

Causes a ton of regressions, gonna need to split xPadNormalizeAnalog off into another file to make `isinf` inline

iScrFx begin and end functions

7da2ca5

iScrFXCameraEndScene WIP

2d7c208

Ensure xPad stuff uses enums/constants for the flags

d66d6c3

LivewireCB reviewed Aug 7, 2025

View reviewed changes

LivewireCB merged commit f5ba1ae into bfbbdecomp:main Aug 7, 2025
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

xPad and xRender work #25

xPad and xRender work #25

Uh oh!

bluisblu commented Jul 22, 2025

Uh oh!

github-actions bot commented Jul 22, 2025

Uh oh!

github-actions bot commented Jul 22, 2025

Uh oh!

github-actions bot commented Jul 25, 2025

Uh oh!

github-actions bot commented Aug 7, 2025

Uh oh!

github-actions bot commented Aug 7, 2025

Uh oh!

LivewireCB left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

xPad and xRender work #25

xPad and xRender work #25

Uh oh!

Conversation

bluisblu commented Jul 22, 2025

Uh oh!

github-actions bot commented Jul 22, 2025

⚠️ 🔥

Regressions: 12

Progress: 34

Uh oh!

github-actions bot commented Jul 22, 2025

⚠️ 🔥

Regressions: 3

Progress: 23

Uh oh!

github-actions bot commented Jul 25, 2025

⚠️ 🔥

Regressions: 3

Progress: 27

Uh oh!

github-actions bot commented Aug 7, 2025

⚠️ 🔥

Regressions: 3

Progress: 28

Uh oh!

github-actions bot commented Aug 7, 2025

⚠️ 🔥

Regressions: 3

Progress: 28

Uh oh!

LivewireCB left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants