Skip to content

xPad and xRender work #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
LivewireCB merged 12 commits into from
Aug 7, 2025
Merged

xPad and xRender work #25

LivewireCB merged 12 commits into from
Aug 7, 2025

Conversation

@bluisblu
Copy link
Contributor

@bluisblu bluisblu commented Jul 22, 2025

Also clang-formatted files that I touched previously

@github-actions
Copy link

github-actions bot commented Jul 22, 2025

⚠️ 🔥

+2632 bytes
🆗 Bot Rating: Amazing contribution, you are the decomp GOAT 🐐

Regressions: 12

⚠️ main/SB/Core/x/xWad4 - .sbss -3 bytes -> 46.32%
⚠️ main/SB/Core/x/xWad4 - .text -743 bytes -> 51.20%
⚠️ main/SB/Core/x/xWad4 - .text -38 bytes -> 35.79%
⚠️ main/SB/Core/x/xWad3 - .text -316 bytes -> 35.71%
⚠️ main/SB/Core/x/xWad1 - .text -8 bytes -> 0.00%
⚠️ main/SB/Core/x/xWad4 - xSG_cb_leader_load(void*, st_XSAVEGAME_DATA*, st_XSAVEGAME_READCONTEXT*, unsigned int, int) -146 bytes -> 26.89%
⚠️ main/SB/Core/x/xWad4 - xSG_cb_leader_svproc(void*, st_XSAVEGAME_DATA*, st_XSAVEGAME_WRITECONTEXT*) -178 bytes -> 26.39%
⚠️ main/SB/Core/x/xWad4 - xSGProcess(st_XSAVEGAME_DATA*) -188 bytes -> 0.00%
⚠️ main/SB/Core/x/xWad4 - xSGSetup(st_XSAVEGAME_DATA*, int, char*, int, long long, int) -159 bytes -> 0.00%
⚠️ main/SB/Core/x/xWad4 - xSGSetup(st_XSAVEGAME_DATA*) -46 bytes -> 2.70%
⚠️ main/SB/Core/x/xWad4 - xSGInit(en_SAVEGAME_MODE) -111 bytes -> 55.56%
⚠️ main/SB/Core/x/xWad4 - PKR_ReadInit(void*, const char*, unsigned int, int*, PKRAssetType*, int) -214 bytes -> 14.43%

Progress: 34

📈 main/SB/Core/x/xWad4 - .text +707 bytes -> 17.00%
📈 main/SB/Core/x/xWad4 - .text +1180 bytes -> 49.54%
📈 main/SB/Core/gc/iWad - .text +11 bytes -> 5.72%
📈 main/SB/Core/x/xWad4 - .text +108 bytes -> 26.43%
📈 main/SB/Core/gc/iWad - .text +604 bytes -> 70.56%
✅ main/SB/Core/x/xWad4 - .text +244 bytes -> 100.00%
📈 main/SB/Core/x/xWad4 - .sdata2 +59 bytes -> 39.00%
✅ main/SB/Core/x/xWad4 - .text +64 bytes -> 100.00%
📈 main/SB/Core/x/xWad4 - xPadUpdate(int, float) +615 bytes -> 45.97%
📈 main/SB/Core/x/xWad4 - PKR_parse_TOC(st_HIPLOADDATA*, st_PACKER_READ_DATA*) +3 bytes -> 17.67%
📈 main/SB/Core/x/xWad4 - xPadNormalizeAnalog(_tagxPad&, int, int) +440 bytes -> 48.89%
📈 main/SB/Core/x/xWad4 - xParGroupAddPar(xParGroup*) +67 bytes -> 39.11%
✅ main/SB/Core/x/xWad4 - xParCmdInit() +684 bytes -> 100.00%
📈 main/SB/Core/x/xWad4 - xParGroupAnimate(xParGroup*, float) +40 bytes -> 6.29%
📈 main/SB/Core/x/xWad4 - xParCmdRotateAround_Update(xParCmd*, xParGroup*, float) +24 bytes -> 8.89%
📈 main/SB/Core/x/xWad4 - xSGGameIsEmpty(st_XSAVEGAME_DATA*, int) +47 bytes -> 31.03%
📈 main/SB/Core/x/xWad4 - PKRStartup() +172 bytes -> 94.74%
📈 main/SB/Core/x/xWad4 - XSGAutoData::SetCache(int, int, int) +36 bytes -> 86.00%
📈 main/SB/Core/x/xWad4 - xPadEnable(int) +24 bytes -> 27.27%
📈 main/SB/Core/gc/iWad - iPadEnable(_tagxPad*, short) +4 bytes -> 22.86%
✅ main/SB/Core/x/xWad4 - xRenderStateSetAlphaDiscard(int) +124 bytes -> 100.00%
📈 main/SB/Core/gc/iWad - iPadStopRumble() +3 bytes -> 37.04%
📈 main/SB/Core/gc/iWad - iPadStopRumble(_tagxPad*) +4 bytes -> 36.00%
✅ main/SB/Core/x/xWad4 - xRenderStateResetAlphaDiscard() +96 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xPadRumbleEnable(int, int) +63 bytes -> 100.00%
📈 main/SB/Core/x/xWad4 - xSG_cb_ISGChange(void*, en_CHGCODE) +3 bytes -> 5.26%
✅ main/SB/Core/x/xWad4 - xRenderBufferInit() +64 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xPadInit() +36 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xRenderFixIMEnd() +4 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xRenderFixIMBegin() +4 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xRenderFixUntexturedEnd(RpAtomic*) +4 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xRenderFixUntexturedBegin(RpAtomic*) +4 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xRenderSceneExit() +4 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xRenderSceneEnter() +4 bytes -> 100.00%

@bluisblu
Disable inline for xWad4
0dbdcba 
Causes a ton of regressions, gonna need to split xPadNormalizeAnalog off into another file to make `isinf` inline
@github-actions
Copy link

github-actions bot commented Jul 22, 2025

⚠️ 🔥

+1364 bytes
🆗 Bot Rating: A fantastic contribution! ✨🎉

Regressions: 3

⚠️ main/SB/Core/x/xWad4 - .sbss -3 bytes -> 46.32%
⚠️ main/SB/Core/x/xWad3 - .text -316 bytes -> 35.71%
⚠️ main/SB/Core/x/xWad1 - .text -8 bytes -> 0.00%

Progress: 23

📈 main/SB/Core/x/xWad4 - .text +988 bytes -> 42.15%
📈 main/SB/Core/gc/iWad - .text +11 bytes -> 5.72%
📈 main/SB/Core/gc/iWad - .text +604 bytes -> 70.56%
✅ main/SB/Core/x/xWad4 - .text +244 bytes -> 100.00%
📈 main/SB/Core/x/xWad4 - .sdata2 +59 bytes -> 39.00%
✅ main/SB/Core/x/xWad4 - .text +64 bytes -> 100.00%
📈 main/SB/Core/x/xWad4 - xPadUpdate(int, float) +615 bytes -> 45.97%
📈 main/SB/Core/x/xWad4 - xPadNormalizeAnalog(_tagxPad&, int, int) +248 bytes -> 27.56%
📈 main/SB/Core/x/xWad4 - xPadEnable(int) +24 bytes -> 27.27%
📈 main/SB/Core/gc/iWad - iPadEnable(_tagxPad*, short) +4 bytes -> 22.86%
✅ main/SB/Core/x/xWad4 - xRenderStateSetAlphaDiscard(int) +124 bytes -> 100.00%
📈 main/SB/Core/gc/iWad - iPadStopRumble() +3 bytes -> 37.04%
📈 main/SB/Core/gc/iWad - iPadStopRumble(_tagxPad*) +4 bytes -> 36.00%
✅ main/SB/Core/x/xWad4 - xRenderStateResetAlphaDiscard() +96 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xPadRumbleEnable(int, int) +63 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xRenderBufferInit() +64 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xPadInit() +36 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xRenderFixIMEnd() +4 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xRenderFixIMBegin() +4 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xRenderFixUntexturedEnd(RpAtomic*) +4 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xRenderFixUntexturedBegin(RpAtomic*) +4 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xRenderSceneExit() +4 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xRenderSceneEnter() +4 bytes -> 100.00%

@github-actions
Copy link

github-actions bot commented Jul 25, 2025

⚠️ 🔥

+1804 bytes
🆗 Bot Rating: A fantastic contribution! ✨🎉

Regressions: 3

⚠️ main/SB/Core/x/xWad4 - .sbss -3 bytes -> 46.32%
⚠️ main/SB/Core/x/xWad3 - .text -316 bytes -> 35.71%
⚠️ main/SB/Core/x/xWad1 - .text -8 bytes -> 0.00%

Progress: 27

📈 main/SB/Core/gc/iScrFX - .text +440 bytes -> 14.96%
📈 main/SB/Core/x/xWad4 - .text +988 bytes -> 42.15%
📈 main/SB/Core/gc/iWad - .text +11 bytes -> 5.72%
📈 main/SB/Core/gc/iWad - .text +604 bytes -> 70.56%
✅ main/SB/Core/x/xWad4 - .text +244 bytes -> 100.00%
📈 main/SB/Core/x/xWad4 - .sdata2 +59 bytes -> 39.00%
✅ main/SB/Core/x/xWad4 - .text +64 bytes -> 100.00%
📈 main/SB/Core/x/xWad4 - xPadUpdate(int, float) +615 bytes -> 45.97%
📈 main/SB/Core/x/xWad4 - xPadNormalizeAnalog(_tagxPad&, int, int) +248 bytes -> 27.56%
📈 main/SB/Core/gc/iScrFX - RenderRect(RwRect*, float) +4 bytes -> 0.89%
✅ main/SB/Core/gc/iScrFX - iScrFxBegin() +240 bytes -> 100.00%
✅ main/SB/Core/gc/iScrFX - iScrFxEnd() +196 bytes -> 100.00%
📈 main/SB/Core/x/xWad4 - xPadEnable(int) +24 bytes -> 27.27%
📈 main/SB/Core/gc/iWad - iPadEnable(_tagxPad*, short) +4 bytes -> 22.86%
✅ main/SB/Core/x/xWad4 - xRenderStateSetAlphaDiscard(int) +124 bytes -> 100.00%
📈 main/SB/Core/gc/iWad - iPadStopRumble() +3 bytes -> 37.04%
📈 main/SB/Core/gc/iWad - iPadStopRumble(_tagxPad*) +4 bytes -> 36.00%
✅ main/SB/Core/x/xWad4 - xRenderStateResetAlphaDiscard() +96 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xPadRumbleEnable(int, int) +63 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xRenderBufferInit() +64 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xPadInit() +36 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xRenderFixIMEnd() +4 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xRenderFixIMBegin() +4 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xRenderFixUntexturedEnd(RpAtomic*) +4 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xRenderFixUntexturedBegin(RpAtomic*) +4 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xRenderSceneExit() +4 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xRenderSceneEnter() +4 bytes -> 100.00%

@github-actions
Copy link

github-actions bot commented Aug 7, 2025

⚠️ 🔥

+2195 bytes
🆗 Bot Rating: Amazing contribution, you are the decomp GOAT 🐐

Regressions: 3

⚠️ main/SB/Core/x/xWad4 - .sbss -3 bytes -> 46.32%
⚠️ main/SB/Core/x/xWad3 - .text -316 bytes -> 35.71%
⚠️ main/SB/Core/x/xWad1 - .text -8 bytes -> 0.00%

Progress: 28

📈 main/SB/Core/gc/iScrFX - .text +832 bytes -> 25.66%
📈 main/SB/Core/x/xWad4 - .text +988 bytes -> 42.15%
📈 main/SB/Core/gc/iWad - .text +11 bytes -> 5.72%
📈 main/SB/Core/gc/iWad - .text +604 bytes -> 70.56%
✅ main/SB/Core/x/xWad4 - .text +244 bytes -> 100.00%
📈 main/SB/Core/x/xWad4 - .sdata2 +59 bytes -> 39.00%
✅ main/SB/Core/x/xWad4 - .text +64 bytes -> 100.00%
📈 main/SB/Core/x/xWad4 - xPadUpdate(int, float) +615 bytes -> 45.97%
📈 main/SB/Core/x/xWad4 - xPadNormalizeAnalog(_tagxPad&, int, int) +248 bytes -> 27.56%
📈 main/SB/Core/gc/iScrFX - iScrFxCameraEndScene(RwCamera*) +391 bytes -> 67.35%
📈 main/SB/Core/gc/iScrFX - RenderRect(RwRect*, float) +4 bytes -> 0.89%
✅ main/SB/Core/gc/iScrFX - iScrFxBegin() +240 bytes -> 100.00%
✅ main/SB/Core/gc/iScrFX - iScrFxEnd() +196 bytes -> 100.00%
📈 main/SB/Core/x/xWad4 - xPadEnable(int) +24 bytes -> 27.27%
📈 main/SB/Core/gc/iWad - iPadEnable(_tagxPad*, short) +4 bytes -> 22.86%
✅ main/SB/Core/x/xWad4 - xRenderStateSetAlphaDiscard(int) +124 bytes -> 100.00%
📈 main/SB/Core/gc/iWad - iPadStopRumble() +3 bytes -> 37.04%
📈 main/SB/Core/gc/iWad - iPadStopRumble(_tagxPad*) +4 bytes -> 36.00%
✅ main/SB/Core/x/xWad4 - xRenderStateResetAlphaDiscard() +96 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xPadRumbleEnable(int, int) +63 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xRenderBufferInit() +64 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xPadInit() +36 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xRenderFixIMEnd() +4 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xRenderFixIMBegin() +4 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xRenderFixUntexturedEnd(RpAtomic*) +4 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xRenderFixUntexturedBegin(RpAtomic*) +4 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xRenderSceneExit() +4 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xRenderSceneEnter() +4 bytes -> 100.00%

@github-actions
Copy link

github-actions bot commented Aug 7, 2025

⚠️ 🔥

+2195 bytes
🆗 Bot Rating: Amazing contribution, you are the decomp GOAT 🐐

Regressions: 3

⚠️ main/SB/Core/x/xWad4 - .sbss -3 bytes -> 46.32%
⚠️ main/SB/Core/x/xWad3 - .text -316 bytes -> 35.71%
⚠️ main/SB/Core/x/xWad1 - .text -8 bytes -> 0.00%

Progress: 28

📈 main/SB/Core/gc/iScrFX - .text +832 bytes -> 25.66%
📈 main/SB/Core/x/xWad4 - .text +988 bytes -> 42.15%
📈 main/SB/Core/gc/iWad - .text +11 bytes -> 5.72%
📈 main/SB/Core/gc/iWad - .text +604 bytes -> 70.56%
✅ main/SB/Core/x/xWad4 - .text +244 bytes -> 100.00%
📈 main/SB/Core/x/xWad4 - .sdata2 +59 bytes -> 39.00%
✅ main/SB/Core/x/xWad4 - .text +64 bytes -> 100.00%
📈 main/SB/Core/x/xWad4 - xPadUpdate(int, float) +615 bytes -> 45.97%
📈 main/SB/Core/x/xWad4 - xPadNormalizeAnalog(_tagxPad&, int, int) +248 bytes -> 27.56%
📈 main/SB/Core/gc/iScrFX - iScrFxCameraEndScene(RwCamera*) +391 bytes -> 67.35%
📈 main/SB/Core/gc/iScrFX - RenderRect(RwRect*, float) +4 bytes -> 0.89%
✅ main/SB/Core/gc/iScrFX - iScrFxBegin() +240 bytes -> 100.00%
✅ main/SB/Core/gc/iScrFX - iScrFxEnd() +196 bytes -> 100.00%
📈 main/SB/Core/x/xWad4 - xPadEnable(int) +24 bytes -> 27.27%
📈 main/SB/Core/gc/iWad - iPadEnable(_tagxPad*, short) +4 bytes -> 22.86%
✅ main/SB/Core/x/xWad4 - xRenderStateSetAlphaDiscard(int) +124 bytes -> 100.00%
📈 main/SB/Core/gc/iWad - iPadStopRumble() +3 bytes -> 37.04%
📈 main/SB/Core/gc/iWad - iPadStopRumble(_tagxPad*) +4 bytes -> 36.00%
✅ main/SB/Core/x/xWad4 - xRenderStateResetAlphaDiscard() +96 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xPadRumbleEnable(int, int) +63 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xRenderBufferInit() +64 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xPadInit() +36 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xRenderFixIMEnd() +4 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xRenderFixIMBegin() +4 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xRenderFixUntexturedEnd(RpAtomic*) +4 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xRenderFixUntexturedBegin(RpAtomic*) +4 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xRenderSceneExit() +4 bytes -> 100.00%
✅ main/SB/Core/x/xWad4 - xRenderSceneEnter() +4 bytes -> 100.00%

LivewireCB
LivewireCB reviewed Aug 7, 2025
View reviewed changes
Copy link
Collaborator

@LivewireCB LivewireCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, The pr looks great. We've already discussed the removal of tagxrumble in the discord.

@LivewireCB LivewireCB merged commit f5ba1ae into bfbbdecomp:main Aug 7, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LivewireCB LivewireCB LivewireCB left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bluisblu @LivewireCB