add the abbility to disable ssl

[ramonskie]

i added a option to disable ssl if needed

[bflad]

== true is redundant and can be removed

[bflad]

Any changes here should also be done in web.xml.erb (for completeness).

[bflad]

Have you had any luck testing? Any way I can help? Thanks!

[ramonskie]

does still need verification?
because i use it for a while now

[ramonskie]

any update on this?

[sunruh]

Some comments/suggestions resulting from a support case investigation together with Atlassian.

• If secure=true is set on the Tomcat connector (which is the case if node['stash']['apache2'] is non-nil) The security-constraint in web.xml is not needed as Tomcat will always assume that a request is secure and will never redirect. URLs generated by JIRA will also always be based below <scheme>://<proxyName>:<proxyPort> unless the display URL is changed in JIRA (which would generate a warning message in the UI).
• As the Apache webapp will only ever connect to the HTTP connector of Tomcat, the HTTPS connector and SSL certificate generation could be left out from the recipe.
• Regarding the deactivation of SSL, I would suggest to disable it if node['stash']['tomcat']['ssl_port'] == -1 rather then indroducing a new attribute.

@bflad If you want me to, I could prepare a PR containing this cleanup (including the possibility to disable SSL). Also have a change which I have to integrate for our internal Stash 3.4 <-> JIRA Applink integration which requires an additional Tomcat connector if behind a reverse proxy (this is the result from the support case with Atlassian).

[bflad]

@ramonskie sorry I never responded to this. Is anyone else using this branch? @sunruh I'd love to see a PR if you have the time, seems very useful to support that situation

[sunruh]

@bflad I just created PR #56 as a replacement for this one. Regarding the 2nd change regarding the App link between Stash and JIRA, I will have to re-investigate again with the current releases of both.