Set plot backgrounds to white for legibility on dark backgrounds#885
Open
rben01 wants to merge 3 commits intobheisler:masterfrom
Open
Set plot backgrounds to white for legibility on dark backgrounds#885rben01 wants to merge 3 commits intobheisler:masterfrom
rben01 wants to merge 3 commits intobheisler:masterfrom
Conversation
Author
|
I think the horizontal blue line in the second screenshot is an artifact of having had web inspector open and not inherent to the output. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR sets plot backgrounds to white in both the gnuplot and plotters backends. I'm not sure how to test this, so for verification, attached are the reports you get when running the following command with and without gnuplot installed:
cargo test --features plotters --features html_reports --test criterion_tests test_output_filescriterion-output.zip
The reports are saved to a tempdir, so if you would like to replicate this yourself, you should place the following at the top of the test function and then add
-- --nocaptureto the command above.Screenshots of the reports in dark mode:
Gnuplot:

Plotters:
