-
Notifications
You must be signed in to change notification settings - Fork 0
test #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test #1
Conversation
|
temp pr to test : Lightning-AI#3306 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR makes infrastructure improvements to the documentation build workflow and Sphinx configuration. The changes focus on resolving documentation build issues and cleaning up unused workflow parameters. While the PR title "test" and incomplete description suggest this may be a work-in-progress, the actual code changes are focused and reasonable.
Key changes:
- Added Sphinx
nitpick_ignoreconfiguration to suppress warnings for unresolvable typing references - Configured linkcheck to ignore a Medium article URL that returns 403 errors to automated clients
- Removed unused
PYPI_CACHEenvironment variable and relatedpypi-dirworkflow parameters that were never defined in the action inputs - Added disk space cleanup step to prevent out-of-disk issues during documentation builds
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| docs/source/conf.py | Added nitpick ignore rules for typing references and excluded Medium article from link checking |
| .github/workflows/docs-build.yml | Removed unused PYPI_CACHE references and added disk space cleanup step to prevent build failures |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Revert "refactor: remove unused PYPI_CACHE variable and update disk space cleanup step" This reverts commit 03916b4.
What does this PR do?
Fixes #<issue_number>
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃