Skip to content

Conversation

@bhimrazy
Copy link
Owner

What does this PR do?

Fixes #<issue_number>

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 28, 2025
@bhimrazy
Copy link
Owner Author

temp pr to test : Lightning-AI#3306

@bhimrazy bhimrazy closed this Nov 28, 2025
@bhimrazy bhimrazy reopened this Dec 2, 2025
Copilot AI review requested due to automatic review settings December 3, 2025 16:45
Copilot finished reviewing on behalf of bhimrazy December 3, 2025 16:47
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR makes infrastructure improvements to the documentation build workflow and Sphinx configuration. The changes focus on resolving documentation build issues and cleaning up unused workflow parameters. While the PR title "test" and incomplete description suggest this may be a work-in-progress, the actual code changes are focused and reasonable.

Key changes:

  • Added Sphinx nitpick_ignore configuration to suppress warnings for unresolvable typing references
  • Configured linkcheck to ignore a Medium article URL that returns 403 errors to automated clients
  • Removed unused PYPI_CACHE environment variable and related pypi-dir workflow parameters that were never defined in the action inputs
  • Added disk space cleanup step to prevent out-of-disk issues during documentation builds

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
docs/source/conf.py Added nitpick ignore rules for typing references and excluded Medium article from link checking
.github/workflows/docs-build.yml Removed unused PYPI_CACHE references and added disk space cleanup step to prevent build failures

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Revert "refactor: remove unused PYPI_CACHE variable and update disk space cleanup step"

This reverts commit 03916b4.
@bhimrazy bhimrazy closed this Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants