Fix "elements" type to accept array instead of only an empty tuple (or null)#572
Open
TomNaessens wants to merge 1 commit intobiati-digital:masterfrom
Open
Fix "elements" type to accept array instead of only an empty tuple (or null)#572TomNaessens wants to merge 1 commit intobiati-digital:masterfrom
TomNaessens wants to merge 1 commit intobiati-digital:masterfrom
Conversation
`[] | null` accepts an empty array, or null, while we want to accept any array (or null): `any[] | null`
TomNaessens
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, 👋
I've encountered an issue when assigning an array of elements to the
GLightbox.Options:The cause is that the type of
elements?: [] | nullaccepts an empty array, or null, while we want to accept any array (or null), so it should have beenany[] | null. I've usedany[]here since the types of the helper methods on elements (setElementsandgetElements) also acceptany[]as types.