Skip to content

Add a --dir command argument for setting the download path#365

Merged
vxbinaca merged 1 commit intobibanon:masterfrom
Andres9890:master
Feb 18, 2026
Merged

Add a --dir command argument for setting the download path#365
vxbinaca merged 1 commit intobibanon:masterfrom
Andres9890:master

Conversation

@Andres9890
Copy link
Contributor

I think this would be pretty useful

tested this and it works

@Andres9890
Copy link
Contributor Author

Also wow 365th that's nice

@brandongalbraith
Copy link
Collaborator

@vxbinaca @mrpapersonic I'm cool with this, but please confirm when time permits y'all see no issues with this.

@vxbinaca
Copy link
Collaborator

Hi where is the actual logic that sets the directory? I'm having trouble understanding what does the actual work on this. I see 90 percent of this is references in either the README.md or what would be the output for a help command and I'm failing to see where the actual function that changes the directory is.

Could this not also be done with a symbolic link?

I'm not opposed to this, just trying to understand where the meat of this is.

@Andres9890
Copy link
Contributor Author

Andres9890 commented Feb 18, 2026

@vxbinaca well the actual directory logic already existed in the core class, what i did was connect the behavior to the cli, and as for the symlink, it def could done with it, but from my own perspective i think the cli arg feels easier and cleaner

for the meat, it's in TubeUp.dir_path where it expands the path and creates the downloads folder inside of it
it's up to you guys if you want it or not

@vxbinaca
Copy link
Collaborator

okay understood it was explained to me like I'm the 5 year old I am, thanks merging. Cool work and thanks again for the PR.

@vxbinaca vxbinaca merged commit ca0fbb5 into bibanon:master Feb 18, 2026
6 checks passed
@Andres9890
Copy link
Contributor Author

No problem, glad i helped

@vxbinaca
Copy link
Collaborator

I tested your PR and it works so thanks again

@Andres9890
Copy link
Contributor Author

Andres9890 commented Feb 18, 2026

@vxbinaca ok so there's a small problem where if --dir is not set it returns none and fails, you would need to add a or '~/.tubeup' fallback to dir_path = args['--dir'] in main.py

i'm very sorry for the inconvenience i caused

@vxbinaca
Copy link
Collaborator

Cut a new PR with the change and I'll merge it. Make sure it alerts the user to the directory problem else try to make directory. Also make sure doing this doesn't cause data loss by clobbering some pre-existing directory.

I'll cut a fixed version tomorrow.

@Andres9890
Copy link
Contributor Author

@vxbinaca on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants