Add a --dir command argument for setting the download path#365
Add a --dir command argument for setting the download path#365vxbinaca merged 1 commit intobibanon:masterfrom
Conversation
|
Also wow 365th that's nice |
|
@vxbinaca @mrpapersonic I'm cool with this, but please confirm when time permits y'all see no issues with this. |
|
Hi where is the actual logic that sets the directory? I'm having trouble understanding what does the actual work on this. I see 90 percent of this is references in either the README.md or what would be the output for a help command and I'm failing to see where the actual function that changes the directory is. Could this not also be done with a symbolic link? I'm not opposed to this, just trying to understand where the meat of this is. |
|
@vxbinaca well the actual directory logic already existed in the core class, what i did was connect the behavior to the cli, and as for the symlink, it def could done with it, but from my own perspective i think the cli arg feels easier and cleaner for the meat, it's in TubeUp.dir_path where it expands the path and creates the downloads folder inside of it |
|
okay understood it was explained to me like I'm the 5 year old I am, thanks merging. Cool work and thanks again for the PR. |
|
No problem, glad i helped |
|
I tested your PR and it works so thanks again |
|
@vxbinaca ok so there's a small problem where if --dir is not set it returns none and fails, you would need to add a i'm very sorry for the inconvenience i caused |
|
Cut a new PR with the change and I'll merge it. Make sure it alerts the user to the directory problem else try to make directory. Also make sure doing this doesn't cause data loss by clobbering some pre-existing directory. I'll cut a fixed version tomorrow. |
|
@vxbinaca on it |
I think this would be pretty useful
tested this and it works