Enhance 7t_trt example with demonstration of "entities-less" physio.json for inheritance principle #476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…son for inheritance principle We already have a single dataset with similar entities less file: ds000248/T1w.json . I decided to enhance this one as it is a nice demonstration of allowance here since there is another metadata file but with a different suffix
effigies
approved these changes
Dec 19, 2024
yarikoptic
requested review from
Lestropie,
Remi-Gau,
robertoostenveld and
rwblair
|
Let's seek few more opinions just to be sure ;) requesting from experts on inheritance and those who touched this example in the past |
Remi-Gau
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already have a single dataset with similar entities less file: ds000248/T1w.json . I decided to enhance this one as it is a nice demonstration of allowance here since there is another metadata file but with a different suffix
To complement