Skip to content

Conversation

julia-pfarr
Copy link
Member

@julia-pfarr julia-pfarr commented Sep 12, 2025

Adds example data to complement bids-standard/bids-specification#1128.

Modifications made from #478

@mszinte @oesteban @Remi-Gau

closes mszinte/bids-specification#3

@julia-pfarr
Copy link
Member Author

@effigies @rwblair let me know when the _physioevents.tsv.gz validation isn't failing anymore, then I convert from draft to open

@julia-pfarr julia-pfarr changed the title [ENH] Bep020 examples [ENH] BEP020 examples Sep 12, 2025
@julia-pfarr julia-pfarr marked this pull request as ready for review September 15, 2025 13:56
@effigies
Copy link
Contributor

@julia-pfarr The main thing missing is ScreenOrigin, in both examples:

	[ERROR] INCOMPLETE_STIMULUS_PRESENTATION `StimulusPresentation` metadata for the events file associated with {path}
({associations.events.path}) must have `ScreenDistance`, `ScreenOrigin`,
`ScreenResolution` and `ScreenSize` fields.

		/sub-01/beh/sub-01_task-FreeView_run-01_recording-eye2_physio.tsv.gz
		/sub-01/beh/sub-01_task-FreeView_run-01_recording-eye1_physio.tsv.gz

		2 more files with the same issue

	Please visit https://neurostars.org/search?q=INCOMPLETE_STIMULUS_PRESENTATION for existing conversations about this issue.


          Summary:                         Available Tasks:        Available Modalities:
          21 Files, 7.69 kB                FreeView                beh                  
          1 - Subjects 1 - Sessions 

@scott-huberty
Copy link

Hi all, I've noticed some updates to the proposed BEP 020 spec bids-standard/bids-specification#1128 .

Do you need me to update the EEG-Eyetracking Example dataset (originally shared here ) in order to match the updated spec?

@julia-pfarr
Copy link
Member Author

julia-pfarr commented Sep 15, 2025

Hi all, I've noticed some updates to the proposed BEP 020 spec bids-standard/bids-specification#1128 .

Do you need me to update the EEG-Eyetracking Example dataset (originally shared here ) in order to match the updated spec?

Hi @scott-huberty, thanks for reminding me that there was this issue and that you wanted to share a BIDS-example as well. Unfortunately, when I click on the link to your dataset or when I search for the dataset number on OpenNeuro, I get an error that I do not have access? Do you know what this is about?

Once I can access the dataset, I can visually inspect it and check with the validator if it needs any updates!

@julia-pfarr
Copy link
Member Author

julia-pfarr commented Sep 16, 2025

	[ERROR] MISSING_FOREIGN_COLUMN The `physioevents.tsv.gz` file declared a `ForeignIndexColumn` of {sidecar.ForeignIndexColumn}, but no such column was found in {associations.physio.path}.

		/sub-01/beh/sub-01_task-FreeView_run-02_recording-eye1_physioevents.tsv.gz
		/sub-01/beh/sub-01_task-FreeView_run-01_recording-eye2_physioevents.tsv.gz

		2 more files with the same issue

@effigies is it because it's empty?

@effigies
Copy link
Contributor

Bug in the schema for loading physio association. Should be fixed now. Triggered a rerun.

@scott-huberty
Copy link

Hi @scott-huberty, thanks for reminding me that there was this issue and that you wanted to share a BIDS-example as well. Unfortunately, when I click on the link to your dataset or when I search for the dataset number on OpenNeuro, I get an error that I do not have access? Do you know what this is about?

Once I can access the dataset, I can visually inspect it and check with the validator if it needs any updates!

Apologies, the dataset was not published, now it is: https://openneuro.org/datasets/ds005872

I'm sure that I will have to update some fields now that the spec has changed.

Copy link
Contributor

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing ForeignIndexColumn to OnsetSource.

Co-authored-by: Chris Markiewicz <[email protected]>
@effigies
Copy link
Contributor

effigies commented Sep 25, 2025

We made OnsetSource (previously ForeignIndexColumn) required in the spec text, but not the schema. I updated that in the schema, and I expect that to fail some of the examples now. I restarted one of the validations to verify.

Nevermind, it looks like it's always set in the current examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

eyetracking dataset examples

4 participants