-
Notifications
You must be signed in to change notification settings - Fork 148
[ENH] BEP020 examples #514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@julia-pfarr The main thing missing is ScreenOrigin, in both examples:
|
Hi all, I've noticed some updates to the proposed BEP 020 spec bids-standard/bids-specification#1128 . Do you need me to update the EEG-Eyetracking Example dataset (originally shared here ) in order to match the updated spec? |
Hi @scott-huberty, thanks for reminding me that there was this issue and that you wanted to share a BIDS-example as well. Unfortunately, when I click on the link to your dataset or when I search for the dataset number on OpenNeuro, I get an error that I do not have access? Do you know what this is about? Once I can access the dataset, I can visually inspect it and check with the validator if it needs any updates! |
@effigies is it because it's empty? |
Bug in the schema for loading physio association. Should be fixed now. Triggered a rerun. |
Apologies, the dataset was not published, now it is: https://openneuro.org/datasets/ds005872 I'm sure that I will have to update some fields now that the spec has changed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing ForeignIndexColumn
to OnsetSource
.
Co-authored-by: Chris Markiewicz <[email protected]>
Nevermind, it looks like it's always set in the current examples. |
Adds example data to complement bids-standard/bids-specification#1128.
Modifications made from #478
@mszinte @oesteban @Remi-Gau
closes mszinte/bids-specification#3