Skip to content

Conversation

mszinte
Copy link

@mszinte mszinte commented Jun 15, 2022

Important

This BEP is under community review from September 29 - October 10, 2025. Please participate at #2218.

Here is the specifications of the BEP 020 about eye tracking.

  • it follows the main discussion initiated on a google document.
  • it includes the different modification the group of maintainers suggested to us during our zoom meeting.
  • it includes the macros as used in other modality specific extensions
  • it includes links toward dataset examples.

Note

We meet regularly and everyone is welcome :
Next meeting April 3rd 2025 4pm UTC (EST 11am, PST 8am, CET 5pm, GMT 4pm) on zoom.

Note that if you consider joining but this time or day doesn't suits you, reach me (@mszinte) and I will arrange another appointment.

Notes of last meeting

Chat and discussions also happening on matrix

We are currently drafing a companion paper for this BEP, feel free to participate (GoogleDoc)

Issues for:


  • implement macros
    • for filename templates ?
    • for examples ?
    • for metadata table
  • add contributors to the wiki (so they can be added to the contributors page)
  • end docmentation
  • update examples
  • update validator
  • update list of contributors via the github wiki

@mszinte mszinte requested a review from tsalo as a code owner June 15, 2022 12:09
correction of text
@sappelhoff sappelhoff added the BEP label Jul 12, 2022
@sappelhoff
Copy link
Member

(NOTE: I'll cross-post this message across several BEP threads)

Hi there, just a quick notification that we have just merged #918 and it may be interesting to look at the implications for this BEP.

We are introducing "BIDS URIs", which unify the way we refer to and point to files in BIDS datasets (as opposed to "dataset-relative" or "subject-relative" or "file-relative" links).

If the diff and discussion in the PR is unclear, you can also read the rendered version: https://bids-specification.readthedocs.io/en/latest/02-common-principles.html#bids-uri

Perhaps there are things in the BEP that need adjusting now, but perhaps also not -- in any case it's good to be aware of this new feature!

Let me know if there are any questions, comments, or concerns.

@tsalo tsalo changed the title [ENH] Bep020 [ENH] BEP 020 Eye Tracking Aug 24, 2022
@julia-pfarr
Copy link
Member

Just a thought on an alternative to ForeignIndexColumn:

  "OnsetSource": "timestamp",
  "OnsetSource": "n/a",

I like this. Do we need a third one, like

"OnsetSource": "index_physio",

to discriminate between totally random onset sources and referencing timestamps in physio.tsv.gz?

@effigies
Copy link
Collaborator

I like this. Do we need a third one, like

"OnsetSource": "index_physio",

to discriminate between totally random onset sources and referencing timestamps in physio.tsv.gz?

I don't think so? n/a indicates indices in physio.tsv.gz, timestamp indicates timestamp values in physio.tsv.gz, and there's no point in encoding totally random.

Copy link
Collaborator

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more foreignindexcolumns

Co-authored-by: Julia-Katharina Pfarr <[email protected]>
@effigies
Copy link
Collaborator

I have opened mszinte#12 to address the two comments in @yarikoptic's review. It is easily addressed in the schema with no validator changes necessary.

@gbezold1 @julia-pfarr @mszinte Would you have a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BEP eye-tracking physio Proposed BEP see https://bids.neuroimaging.io/collaboration/governance.html#proposed-bep

Projects

None yet

Development

Successfully merging this pull request may close these issues.