-
Notifications
You must be signed in to change notification settings - Fork 188
[ENH] microelectrode electrophysiology specification (BEP032) #1705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yarikoptic
wants to merge
144
commits into
master
Choose a base branch
from
bep032
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
144 commits
Select commit
Hold shift + click to select a range
7ec5d5e
Add first BEP032 objects
JuliaSprenger 2f393ca
Add ephys modality, start adding _channels but ran into a question on…
yarikoptic 648781a
Add _acq- to ephys, add _channels and _coords
yarikoptic d3c9996
Draft for probes TSV file
TheChymera 08c92cd
Fix preferably typo
yarikoptic e2030ac
Comment out not yet defined iephys and add ephys to datatypes where i…
TheChymera 53f1087
Added probes file
TheChymera fa648fe
Describe modality/datatype as "Microelectrode Electrophysiology"
yarikoptic eef67df
Remove iephys entirely since I think it was just inspired by DANDI la…
yarikoptic 27547f9
Initial content for ephys document and initial filename template tree
yarikoptic a6ae5e2
Merge remote-tracking branch 'upstream/master' into bep032
Remi-Gau 9a20e4b
pacify pre-commit
Remi-Gau 7609276
add to TOC
Remi-Gau 9be41f9
semantic line break and fix
Remi-Gau 983975a
Addressed minor left over lint complains
yarikoptic 1afdc40
Add "Microelectrode" specialization for Electrophysiology in the cont…
yarikoptic 6b39d64
Fix up for bad latin and adjust wording a bit
yarikoptic f08b163
Replace fancy unicode “ with simple " .
yarikoptic 73012b3
Use redirected to www.datalad.org and www.nwb.org website URLs and fe…
yarikoptic a46e439
BEP032: ephys -> microephys with {icephys, ecephys} modalities/suffix…
yarikoptic 05e9611
Clarify wording and do mention `microephys` as shorthand for Microele…
yarikoptic 7ddeb75
Adding markdown portion of the Bep032 (#1960)
Peyman-N 2b9e757
[ENH] Schema changes related to BEP032 (#1826)
ree-gupta 6b11f54
Merge remote-tracking branch 'origin/master' into bep032
yarikoptic 1abebea
Some fixes of formatting and URLs
yarikoptic 2a3757d
Merge remote-tracking branch 'origin/master' into bep032
yarikoptic 3f4e941
Adjusted some formatting and some wording at the beginning of the sec…
yarikoptic 0853f8a
Few fixes to the schema from review
yarikoptic 800ba58
Adopting the markdown line lengths for BEP032 (#2012)
Peyman-N 46c91b0
Fix tabulation in a .tsv + convert to use yaw, pitch, roll
yarikoptic a884604
Add types and min/max for roll,pitch,yaw + fix typo for microephysCha…
yarikoptic 262d5b1
Replace Pharmaceuticals with already existing fields and fix few more…
yarikoptic 756c07c
Merge remote-tracking branch 'origin/master' into bep032
yarikoptic 7bc17cc
Make use of merged fancing for tsvs and add a note about spotted Phar…
yarikoptic d5fef1f
Remove some "bad latin"
yarikoptic 039fbb3
Fix a link to be final, before redirects
yarikoptic 8e65a63
using MACROS___make_sidecar_table
Peyman-N 2e3be31
numbering
Peyman-N 1762f6f
Adding icephys and ecephys to filename template
Peyman-N 1229a4a
Merge pull request #2034 from Peyman-N/bep032-peyman
yarikoptic 04c1b93
[ENH] Added microephys tag to electrode related enums
ree-gupta 1fd8139
[ENH] Added additional channel enums for microphys
ree-gupta 94de4e5
[ENH] Enlisted microphys channel types in type__channels
ree-gupta 5bc95b0
Merge pull request #2038 from ree-gupta/bep032
yarikoptic b171eee
Various small fixes from code-review
yarikoptic 73083d8
[BEP032] Moved coord system related entities to correct yaml
ree-gupta 50a38db
Minor tuneups from code review (mostly on wording)
yarikoptic 73976f1
A pass to harmonize to use "microephys" in favor over "ephys"
yarikoptic 387b924
Encode in schema that ATM we do require _electodes and _probes
yarikoptic d791dc5
One more ephys -> microephys
yarikoptic 41dfec7
Add .json to data (nwb and nix) and _probes files
yarikoptic cf7e0c6
Merge remote-tracking branch 'origin/master' into bep032
yarikoptic 1242dcd
[DATALAD RUNCMD] replace fancy unicode double quote with a simpler one
yarikoptic 6360b9e
Address many remark lint issues using
yarikoptic 187e6a0
One more tune up
yarikoptic 7b00a28
items
yarikoptic 7954586
[DATALAD RUNCMD] Fix up itemized things indentation
yarikoptic 8ad8a97
Address leftover of remark lint warnings
yarikoptic 4a2a4b4
Merge branch 'bids-standard:bep032' into bep032
ree-gupta 3467824
Remove custom paragraph on participants, replaced angles with yaw, pi…
yarikoptic fae456f
Merge branch 'master' into bep032
bendichter 54f8180
Merge branch 'master' into bep032
CodyCBakerPhD 05fcf7d
Merge branch 'master' into bep032
CodyCBakerPhD fafe10d
[FIX] BEP032 - Correcting validations against real data example (#2132)
CodyCBakerPhD 19845a7
Merge branch 'master' into bep032
CodyCBakerPhD 660317c
Merge branch 'master' into bep032
CodyCBakerPhD 6201738
fix: validation rules for events
CodyCBakerPhD 75787ed
doc: Reorder required metadata files for microephys sessions and clar…
bendichter d71247c
remove unneeded fields
CodyCBakerPhD 49138dc
move to task.yaml with __
CodyCBakerPhD 2cea859
remove from microephys
CodyCBakerPhD 53ad87b
Update src/modality-specific-files/microelectrode-electrophysiology.md
bendichter 9ca3066
Merge pull request #2153 from bids-standard/bens-reorg
bendichter 937f9f5
Merge branch 'bep032' into fix_rules_bep032
CodyCBakerPhD 62994c7
Merge pull request #2152 from bids-standard/fix_rules_bep032
CodyCBakerPhD 3307e6c
chore: linting
CodyCBakerPhD 28a6199
Merge branch 'bids-standard:bep032' into bep032
ree-gupta afbdaed
Merge branch 'master' into bep032
bendichter 477719c
Add comprehensive stereotaxic coordinate documentation with visual gu…
bendichter d3c3d24
Merge branch 'bep032' into bep32_rotation
bendichter 530b22f
Add probe position columns for AP and ML axes and standardize units
bendichter 65ff204
Merge branch 'bep32_rotation' of https://github.com/bids-standard/bid…
bendichter 6f533a6
Update microelectrode electrophysiology documentation
bendichter b59f0b2
Merge branch 'bep032' into bep32_rotation
bendichter 18ad16b
Merge pull request #2160 from bids-standard/bep32_rotation
bendichter 526c6c6
Merge branch 'bids-standard:bep032' into bep032
ree-gupta 18ce69f
Updated probe tabular rule to match AP, ML, DV
ree-gupta d4190e6
Removed coordystem completely
ree-gupta 4e44e0a
Removes coordsys macro to fix failing mkdocs build
ree-gupta c5e2183
change the electrode positions back from AP/ML/DV to x,y,z
bendichter c921f9b
Update _probes.tsv example with standardized coordinate system and Pr…
bendichter 1dff1da
Merge pull request #2058 from ree-gupta/bep032
ree-gupta c342954
Merge branch 'master' into bep032
CodyCBakerPhD ef188c8
Update microephys entity rules and remove task/run requirements
ree-gupta 7f7bac3
Merge branch 'bids-standard:bep032' into bep032
ree-gupta 8485367
Fix linter issues
ree-gupta 068fdc0
Reorganized to match other modalities
ree-gupta 24223af
Merge pull request #2194 from ree-gupta/bep032
ree-gupta d05b4a6
Clarify DV axis description in microelectrode electrophysiology docum…
bendichter 80e9119
Update src/modality-specific-files/microelectrode-electrophysiology.md
effigies 649a2ce
Adds space entity for microephys electrodes
ree-gupta b84bd49
Add coordinate system metadata fields for microephys
ree-gupta cfd64cc
Added rules to 1) override rule for coorsystem to be present for elec…
ree-gupta 198e365
Added entities for the photo specific to microephys
ree-gupta cf3e7a9
Rewrote the coordsystem JSON and photo section to align with ieeg but…
ree-gupta 2f3069f
Minor change to the default probe relative coordinate system
ree-gupta 4395dcf
Probe interface exaple file tree
ree-gupta e295e74
Resolve merge conflict due to reorganization of events from task.yaml…
ree-gupta f3640c0
Merge branch 'master' into bep032
CodyCBakerPhD dada00c
Merge pull request #2198 from ree-gupta/bep032
ree-gupta c272e01
Merge branch 'master' into bep032
CodyCBakerPhD c31f579
Add omission of microephys datatypes for overall channel file rule
ree-gupta d7437f5
Merge branch 'master' into bep032
bendichter 101c01a
Update src/modality-specific-files/microelectrode-electrophysiology.md
bendichter 55401ec
Merge branch 'bep032' into bep032
ree-gupta 84f44f1
Merge pull request #2224 from ree-gupta/bep032
ree-gupta 54a44d4
Update src/modality-specific-files/microelectrode-electrophysiology.md
bendichter 6a9cf98
Update src/modality-specific-files/microelectrode-electrophysiology.md
bendichter 47cca5f
Fix indentation for note and example alerts
yarikoptic e049ef9
Merge branch 'master' into bep032
bendichter 59e1267
[MISC] Use Levels and custom json for probe interface files
bendichter 94b09d8
Update src/modality-specific-files/microelectrode-electrophysiology.md
bendichter 45a06b7
Update src/schema/objects/columns.yaml
bendichter 89fa748
Update src/modality-specific-files/microelectrode-electrophysiology.md
bendichter 551f5de
[MISC] Replace image syntax with HTML for anatomical reference diagrams
bendichter 40e7a5d
Merge branch 'bep032' of https://github.com/bids-standard/bids-specif…
bendichter cc7fe98
Fix formatting in example *_electrodes.tsv for improved readability
bendichter ad41192
Apply suggestion from @bendichter
bendichter da05a28
Remove channel_id def and use name__channels same as ieeg
ree-gupta d9266b7
Update microephys electrode.tsv to match ieeg
ree-gupta 4fc8ec8
Changed probe_id to probe_name to avoid use of the concept ID against…
ree-gupta 8a933ec
Merge branch 'bids-standard:bep032' into bep032
ree-gupta 79f1059
Add missing probe_height def and rewrite desc to match current markdown
ree-gupta 40993d2
Fixed minor typo failing schema validation
ree-gupta 41b301d
Fix remark linting issues
ree-gupta 4c95199
Added and modified texts for coordsystem requirements
ree-gupta 05d19bf
Added icephys and ecephys distinction and restructured first section …
ree-gupta a127f57
Fixed initial_column to match AP, ML, DV
ree-gupta 4c776e5
Update mock TSV and JSON and fix heading levels to match ieeg
ree-gupta d428dc8
Updated toy data section and links to example to match current spec
ree-gupta 73d3975
Minor formatting and style issues
ree-gupta 7fb3a28
Fix mock data tsv and JSON
ree-gupta 8b39a2d
Merge branch 'master' into bep032
CodyCBakerPhD 1cfa706
Apply various wording suggestions from code review
yarikoptic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
--- | ||
ephys: | ||
suffixes: | ||
- ephys | ||
extensions: | ||
- .nwb | ||
# possible future: serialization in .zarr format to accompany .ome.zarr | ||
# - .nwb.zarr | ||
- .nix | ||
datatypes: | ||
- ephys | ||
entities: | ||
subject: required | ||
session: optional | ||
sample: optional | ||
task: optional | ||
run: optional | ||
split: optional | ||
yarikoptic marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NWB files that exceed 2GB are not "conventionally" split into multiple parts. I don't know if this is true for NIX but I doubt it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should look into https://bids-specification.readthedocs.io/en/stable/appendices/entities.html#split may be it would apply
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bendichter is NWB also providing internal pointers to the next split file? The next comments only explain the
.fif
split files further.@ree-gupta is this split also true for
.nix
files?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
based on discussion with @yarikoptic rewrite to having a broader application for split for long data recordings in general. keep fif as concrete example for the specific handling of splits within a software/for a data format.