Skip to content

[MISC] Add shellcheck checks to ensure that those few shell scripts we have are "robust" #1774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 16, 2024
Merged

[MISC] Add shellcheck checks to ensure that those few shell scripts we have are "robust" #1774

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a4c3c0d
Add pre-commit definition for shellcheck
yarikoptic Apr 12, 2024
a89b1bf
Add "" for a variable use in a test_tag script
yarikoptic Apr 12, 2024
51274f2
Add github action to shellcheck master on push and PRs
yarikoptic Apr 12, 2024
a8a891c
Skip shellcheck on ci for pre-commit -- needs docker
yarikoptic Apr 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,3 +64,7 @@ repos:
- types-tabulate
args: ["tools/schemacode/bidsschematools"]
pass_filenames: false
- repo: https://github.com/koalaman/shellcheck-precommit
rev: v0.9.0
hooks:
- id: shellcheck
2 changes: 1 addition & 1 deletion scripts/test_tag
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
EPOCH="$(date +%s)"

GIT_DIR=$( git rev-parse --git-dir )
REPO_ROOT=$( ls -d ${GIT_DIR%.git} )
REPO_ROOT=$( ls -d "${GIT_DIR%.git}" )

VERSION_FILE="$REPO_ROOT/src/schema/SCHEMA_VERSION"

Expand Down