-
Notifications
You must be signed in to change notification settings - Fork 188
[ENH] Additional age related columns for participants.tsv file to cover animal data #1839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from 42 commits
eebdb15
e6f4325
793a6d8
95804e4
2f6531b
bb04dc4
8612a98
cfca31d
c558d50
ae2ecab
5135dd4
edbd4b5
f9e5f68
1ad25d4
33895b0
30f6ec0
86ffb22
e7c02b2
f0547cd
9aedef1
761dd5d
46cdce4
31a72fc
13bbb47
b7cbbb9
00fb641
66b6db0
0954ee5
b80dbbb
193d498
6a3d382
f6c4648
d3a22a7
fc20daf
e784589
e3e0349
31a9cfb
9efd17c
fdc1cc7
1e775de
ae7b7cf
28a064f
7437e04
5610b3d
d39b191
e0aea95
3d955e9
478ccc7
a7a31a3
a308042
285931c
332fd0b
20d1230
bb3513c
b6a5b37
c739904
43c52fc
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. birth, fertilization and gestation deleted from the enums |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -49,6 +49,17 @@ AcquisitionVoxelSize: | |
type: number | ||
exclusiveMinimum: 0 | ||
unit: mm | ||
AgeReference: | ||
name: AgeReference | ||
display_name: Age Reference | ||
description: | | ||
Non-numeric term of for a time point in a subject's life cycle that serves | ||
as reference for the numeric age information (for instance, 'start of embryo stage'). | ||
type: string | ||
enum: | ||
- $ref: objects.enums.fertilization.value | ||
- $ref: objects.enums.gestation.value | ||
- $ref: objects.enums.birth.value | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. do we need this? How is this different from the age_reference in the Participants table? @yarikoptic There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is a result of back/forth recommendations of where to integrate the age reference. This is the comment #1839 (comment) with the hopefully final decision on how to solve this. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. From what I see in the comment this should not be deleted. |
||
Anaesthesia: | ||
name: Anaesthesia | ||
display_name: Anaesthesia | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -57,3 +57,10 @@ genetic_info: | |
TissueOrigin: optional | ||
BrainLocation: optional | ||
CellType: optional | ||
|
||
participants: | ||
selectors: | ||
- path == "/participants.json" | ||
- '"age" in columns' | ||
fields: | ||
AgeReference: recommended | ||
Comment on lines
+62
to
+67
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does this fit with #1839 (comment) ? If yes this should also recommend age unit not only the age reference There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not sure if this is also the place for defining |
Uh oh!
There was an error while loading. Please reload this page.