[ENH] Add 2015 reconstruction of BigBrain as a template coordinate space #2151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te coordinate space
for more information, see https://pre-commit.ci
yarikoptic
previously requested changes
Jul 3, 2025
src/schema/objects/enums.yaml
Outdated
| The sections were stained for cell bodies, so the model displays cytoarchitectural structures such as cortical layers. | ||
| The BigBrain was published in [Amunts et al., Science 2013](https://doi.org/10.1126/science.1235381). | ||
| This identifier refers to the 2015 version of the 3D reconstruction hosted at [https://ftp.bigbrainproject.org/bigbrain-ftp/BigBrainRelease.2015/](https://ftp.bigbrainproject.org/bigbrain-ftp/BigBrainRelease.2015/), which comprises almost a Terabyte of image data. | ||
| The 3D reconstruction can be viewed online at [EBRAINS](https://atlases.ebrains.eu/viewer/go/bigbrain) and accessed programmatically using [siibra-python](https://siibra-python.readthedocs.io). |
There was a problem hiding this comment.
I think indentation here jumps thus making it invalid yaml and I guess (didn't check) it is what makes CI red.
Also I do not think we use Markdown in such descriptions ATM -- please reformat to be similar to other entries.
effigies
reviewed
Aug 1, 2025
effigies
reviewed
Sep 5, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2151 +/- ##
=======================================
Coverage 82.71% 82.71%
=======================================
Files 20 20
Lines 1608 1608
=======================================
Hits 1330 1330
Misses 278 278 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
effigies
approved these changes
Sep 5, 2025
There was a problem hiding this comment.
This LGTM. @yarikoptic Are you still concerned about the markdown?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose to add BigBrain as a known template space. This will help us to properly model a couple of incoming EBRAINS datasets in a BIDS conform way.