Skip to content

[WIP] Suggested modifications to directory layout of the bids-study DatasetType #2191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

[WIP] Suggested modifications to directory layout of the bids-study DatasetType #2191

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b99a7bd
Suggested modifications to directory layout of the bids-study Dataset…
nikhil153 Sep 2, 2025
2d59198
fixed minor typos
nikhil153 Sep 2, 2025
7fc71c7
Merge branch 'bids-standard:master' into master
nikhil153 Sep 9, 2025
e0fe3ce
removed bids prefix from the DatasetType and subdirs.
nikhil153 Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/schema/rules/directories.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,11 @@ study:
subdirs:
- code
- docs
- rawdata
- derivatives
- logs
- sourcedata
- phenotype
code:
name: code
level: optional
Expand All @@ -32,6 +34,10 @@ study:
name: docs
level: optional
opaque: true
rawdata:
name: rawdata
level: optional
opaque: true
derivatives:
name: derivatives
level: optional
Expand All @@ -44,6 +50,10 @@ study:
name: sourcedata
level: optional
opaque: true
phenotype:
name: phenotype
level: optional
opaque: false
Comment on lines +53 to +56
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was removed after this discussion: #2185 (comment)

I didn't see a justification for re-adding it, so I want to make sure this isn't slipped in with little consideration.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, should have explained this addition based on offline conversations.
The reason for removing phenotype directory was that it would presumably appear in the raw dataset. But isn't that true for derivatives directory as well? It's a bit confusing having derivatives part of all three DatasetTypes but enforcing phenotype only be part of raw or derivative. In practice, phenotype data curation is likely to be more independent than that of derivatives, which is one of the reasons we prefer it to be at the top level.


raw:
root:
Expand Down
Loading