Skip to content

Comments

chore(deps): Bump hed-validator dependency to 4.1.4#220

Merged
effigies merged 10 commits intobids-standard:mainfrom
happy5214:bump-hed-validator-4.1.0
Aug 11, 2025
Merged

chore(deps): Bump hed-validator dependency to 4.1.4#220
effigies merged 10 commits intobids-standard:mainfrom
happy5214:bump-hed-validator-4.1.0

Conversation

@happy5214
Copy link
Contributor

This version includes multiple changes. While most relate to the new browser validation functionality and don't directly affect BIDS, some changes affecting BIDS include TypeScript type declarations and general bug fixes.

@happy5214
Copy link
Contributor Author

We'll have to have to fix the type errors (some are easier, some are harder) and issue a new release. Closing for now.

@happy5214 happy5214 closed this Aug 5, 2025
@happy5214 happy5214 reopened this Aug 7, 2025
@happy5214 happy5214 changed the title Bump hed-validator dependency to 4.1.0 Bump hed-validator dependency to 4.1.1 Aug 7, 2025
@happy5214
Copy link
Contributor Author

The type issues should be fixed now. I had two dataset issues locally, but they appeared to be unrelated to HED.

@happy5214
Copy link
Contributor Author

I'm leaving you to fix the esbuild issues. node: prefixes are preferred nowadays for core libraries, so I prefer not to change those.

@effigies effigies added the no changelog Use to prevent changelog check from being run. label Aug 7, 2025
@effigies
Copy link
Contributor

effigies commented Aug 7, 2025

Not sure how to deal with this, TBH. I made some minor changes to build.ts to make the build pass, but that seems to break the actual execution.

I give up. This should solve the issues once and for all.
@happy5214
Copy link
Contributor Author

happy5214 commented Aug 9, 2025

I give up. Unless you have any more ideas, I'm content to freeze the dependency at 4.0.1 until we port hed-validator to TypeScript.

@VisLab
Copy link
Member

VisLab commented Aug 11, 2025

I think we should release hed-validator 4.1.3 with the node bump to version 22 and try that. Will requiring node 22 be a problem?

@effigies
Copy link
Contributor

Only @nellh can say. I don't understand the compatibility issues with node and deno.

@happy5214
Copy link
Contributor Author

There is a bug in the esbuild-deno-loader package that is causing the node: namespaces to be stripped from the package imports. This makes releasing version 4.1.3 of hed-validator pointless. I submitted lucacasonato/esbuild_deno_loader#170 in a hope to fix the issue upstream, but I'm not optimistic it will be merged soon.

This will hopefully fix the build issues once hed-validator 4.1.3
is released.
@happy5214
Copy link
Contributor Author

I replaced the Deno esbuild plugin with the "official" one. It should be fixed once the new version of hed-validator is released.

happy5214 and others added 4 commits August 11, 2025 09:12
Hopefully, this is the last bump needed for a while.
That may have been important after all.
If this fails, I give up.
@effigies effigies changed the title Bump hed-validator dependency to 4.1.1 chore(deps): Bump hed-validator dependency to 4.1.4 Aug 11, 2025
Copy link
Contributor

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, I was able to undo the modifications to build.ts, so thanks for figuring this all out on your end. This was definitely beyond me.

@effigies effigies merged commit 8bae350 into bids-standard:main Aug 11, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changelog Use to prevent changelog check from being run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants