Throw an error, do not just log an error, if provided schema is not legit #270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yarikoptic
changed the title
effigies
approved these changes
Sep 18, 2025
…readable I think current behavior violates the principle of the least surprise: I ran validation while providing custom schema source, it executed with many warnings and errors reported to the screen. It is only after scrolling far up, I saw that actually my specification was wrong and operation resorted to built-in schema. amend: removed comment "version is ignored when the network cannot be accessed"
yarikoptic
force-pushed
the
enh-crash
branch
from
f53dc84 to
7d105ff
Compare
|
What do you think about the case where someone has BIDS_SCHEMA in their environment but doesn't know it. Should we indicate where the URL came from? |
|
that might come useful although I do not think any other software I know bothers to tell apart where config value came from. If to add -- do you feel it is better as error post-processing (check again if env var available) or pair with and add some |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think current behavior violates the principle of the least surprise: I ran validation while providing custom schema source, it executed with many warnings and errors reported to the screen. It is only after scrolling far up, I saw that actually my specification was wrong and operation resorted to built-in schema.
Moreover, having varying results depending on network flukes is also not a good behavior.
TODOs (if agreed in principle)