-
Notifications
You must be signed in to change notification settings - Fork 129
[ENH] Use BIDS schema to "drive" pybids #818 #1163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1163 +/- ##
==========================================
+ Coverage 89.37% 89.48% +0.11%
==========================================
Files 66 70 +4
Lines 7276 7828 +552
Branches 854 951 +97
==========================================
+ Hits 6503 7005 +502
- Misses 565 584 +19
- Partials 208 239 +31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Awesome, will start with trying the notebook! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sold!
Legacy initialization: 1.531 seconds
Schema initialization: 1.282 seconds
Difference: 0.249 seconds
Schema is faster by 16.3%
Get the CI passing and will approve, although I think folks will want to increase coverage, so maybe that too?
=== Do not change lines below ===
{
"chain": [],
"cmd": "uv lock",
"exit": 0,
"extra_inputs": [],
"inputs": [
"pyproject.toml"
],
"outputs": [
"uv.lock"
],
"pwd": "."
}
^^^ Do not change lines above ^^^
f629a7d to
d44bb7b
Compare
|
Hi @bendhouseart, I've improved code coverage, and CI looks to be passing. :) |
This is my first PR as a BIDS maintainer. Appreciate any feedback! This attempts to address #818.
Summary
BIDSLayoutconfiguration loadingImplementation
Config._from_schema()method that loads schema viabidsschematools.schema.load_schema()rules.regexify_filename_rules()bids_schema.objects.formats)Usage