Add functionality that you can lint your translation files (feature)#205
Open
buchtadan wants to merge 1 commit intobiesbjerg:masterfrom
Open
Add functionality that you can lint your translation files (feature)#205buchtadan wants to merge 1 commit intobiesbjerg:masterfrom
buchtadan wants to merge 1 commit intobiesbjerg:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a new feature that allows user to configure wether they want to create a translation file(s) or check if the given translation file(s) has already all the necessary translation-key's in it.
The intension behind this feature was, that you can integrate a 'translate-extract-check' to an ci pipeline or so.
Not sure if you want to add it in this repro or if you see it more in an other package, something like
ngx-translate-linteror so.It helped us in our project, but we had to create an extra fork, merge this functionality, publish it and so. So I would love to see this feature, not only because it would help us but more towards that I think it's a good addition.
Keep up the great work.
Let me know what you think and greetings.