Conversation
Add big example
📝 WalkthroughWalkthroughThis PR adds support for testing and documenting a large-scale DIA dataset (PXD062383) by introducing a new CI job that downloads and processes the dataset with MultiQC, along with corresponding documentation and configuration entries. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@docs/README.md`:
- Around line 252-255: The Markdown under the heading "### 🔍 Large-Scale
Dataset Reports" violates MD058 because the table immediately follows the
heading without a blank line; fix by inserting a single blank line between the
"### 🔍 Large-Scale Dataset Reports" heading and the table start (the line
beginning with "| Example Type | Description | Link | Dataset Download |") so
the table is separated from the heading.
🧹 Nitpick comments (1)
.github/workflows/python-app.yml (1)
299-302: Consider adding retries/timeouts for the large dataset download.Given the size of PXD062383, adding retries/timeouts reduces flaky CI failures due to transient network issues.
✅ Optional hardening
- wget -nv https://ftp.pride.ebi.ac.uk/pub/databases/pride/resources/proteomes/pmultiqc/example-projects/PXD062383.zip + wget -nv --retry-connrefused --waitretry=1 --read-timeout=20 --timeout=20 --tries=5 \ + https://ftp.pride.ebi.ac.uk/pub/databases/pride/resources/proteomes/pmultiqc/example-projects/PXD062383.zip
| ### 🔍 Large-Scale Dataset Reports | ||
| | Example Type | Description | Link | Dataset Download | | ||
| |---|---|---|---| | ||
| | Big quantms DIA | Data-independent acquisition | [Big quantms DIA - 165 samples](https://pmultiqc.quantms.org/PXD062383/multiqc_report.html) ([disable_hoverinfo](https://pmultiqc.quantms.org/PXD062383_disable_hoverinfo/multiqc_report.html)) | [PXD062383.zip](https://ftp.pride.ebi.ac.uk/pub/databases/pride/resources/proteomes/pmultiqc/example-projects/PXD062383.zip) | |
There was a problem hiding this comment.
Add a blank line before the table (MD058).
This section is missing a blank line before the table, which triggers markdownlint MD058.
🩹 Suggested fix
-### 🔍 Large-Scale Dataset Reports
-| Example Type | Description | Link | Dataset Download |
+### 🔍 Large-Scale Dataset Reports
+
+| Example Type | Description | Link | Dataset Download |📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| ### 🔍 Large-Scale Dataset Reports | |
| | Example Type | Description | Link | Dataset Download | | |
| |---|---|---|---| | |
| | Big quantms DIA | Data-independent acquisition | [Big quantms DIA - 165 samples](https://pmultiqc.quantms.org/PXD062383/multiqc_report.html) ([disable_hoverinfo](https://pmultiqc.quantms.org/PXD062383_disable_hoverinfo/multiqc_report.html)) | [PXD062383.zip](https://ftp.pride.ebi.ac.uk/pub/databases/pride/resources/proteomes/pmultiqc/example-projects/PXD062383.zip) | | |
| ### 🔍 Large-Scale Dataset Reports | |
| | Example Type | Description | Link | Dataset Download | | |
| |---|---|---|---| | |
| | Big quantms DIA | Data-independent acquisition | [Big quantms DIA - 165 samples](https://pmultiqc.quantms.org/PXD062383/multiqc_report.html) ([disable_hoverinfo](https://pmultiqc.quantms.org/PXD062383_disable_hoverinfo/multiqc_report.html)) | [PXD062383.zip](https://ftp.pride.ebi.ac.uk/pub/databases/pride/resources/proteomes/pmultiqc/example-projects/PXD062383.zip) | |
🧰 Tools
🪛 markdownlint-cli2 (0.18.1)
253-253: Tables should be surrounded by blank lines
(MD058, blanks-around-tables)
🤖 Prompt for AI Agents
In `@docs/README.md` around lines 252 - 255, The Markdown under the heading "###
🔍 Large-Scale Dataset Reports" violates MD058 because the table immediately
follows the heading without a blank line; fix by inserting a single blank line
between the "### 🔍 Large-Scale Dataset Reports" heading and the table start
(the line beginning with "| Example Type | Description | Link | Dataset Download
|") so the table is separated from the heading.
Pull Request
Description
Brief description of the changes made in this PR.
Type of Change
Summary by CodeRabbit
New Features
Documentation
✏️ Tip: You can customize this high-level summary in your review settings.