Add BioSample Accession column to SDRF-Proteomics format#747
Add BioSample Accession column to SDRF-Proteomics format#747
Conversation
|
@ypriverol 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs. I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review. |
Co-authored-by: ypriverol <52113+ypriverol@users.noreply.github.com>
|
@copilot Can you do the PR against dev branch not master? |
I've successfully rebased the PR to use the The changes include:
The PR now incorporates all the latest changes from the dev branch and applies the BioSample Accession feature on top of that. All changes are minimal and focused on adding the new optional column without breaking existing functionality. Commit: e5fe9fd |
|
@copilot I think you need to close this PR, and start a new one but with your fix against the dev branch, not against the master branch. |
I've created a new branch
This addresses the updated file structure in the dev branch (templates moved to |
This PR adds support for linking proteomics samples with EBI BioSamples through a new optional
characteristics[BioSample Accession]column in the SDRF-Proteomics format.Changes Made
Documentation Updates:
characteristics[BioSample Accession]column insdrf-proteomics/README.adocSAMEA115947232templates/core-templates/README.adoc(marked as optional for all templates)Template Updates:
characteristics[BioSample Accession]column to all 6 core template files:templates/core-templates/sdrf-default.sdrf.tsvtemplates/core-templates/sdrf-human.sdrf.tsvtemplates/core-templates/sdrf-vertebrates.sdrf.tsvtemplates/core-templates/sdrf-invertebrates.sdrf.tsvtemplates/core-templates/sdrf-plants.sdrf.tsvtemplates/core-templates/sdrf-cell-line.sdrf.tsvBenefits
SAMEA115947232not availablewhen no BioSample existsImplementation Notes
This PR is based on the
devbranch to incorporate the latest repository structure changes, including the reorganization of templates into thetemplates/core-templates/directory.Validation
The changes have been tested with the sdrf-pipelines validation tool and do not break existing functionality. The new column is accepted by the validator without issues.
Fixes #745.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.