fix/replay-crash-mobile-shortcuts-webcams#300
Merged
antobinary merged 4 commits intobigbluebutton:developfrom May 29, 2025
Beldaa:fix/webcams-null-currenttime
Merged
fix/replay-crash-mobile-shortcuts-webcams#300antobinary merged 4 commits intobigbluebutton:developfrom Beldaa:fix/webcams-null-currenttime
antobinary merged 4 commits intobigbluebutton:developfrom
Beldaa:fix/webcams-null-currenttime
Conversation
- This error can crash session replays when student webcams are disabled via moderation
Member
|
Much appreciated, @Beldaa ! |
germanocaumo
approved these changes
May 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🐛 What does this PR fix?
This PR resolves two issues that caused session replays to crash, especially on mobile devices and in moderated classrooms:
Broken keyboard shortcut cleanup
Improper use of removeEventListener with only one argument was causing the following error:
TypeError: Failed to execute 'removeEventListener' on 'EventTarget': 2 arguments requiredWebcam replay crash due to null video reference
When student webcams are disabled (e.g., via moderation), the video element may be missing, causing:
Uncaught TypeError: Cannot read properties of null (reading 'currentTime')✅ Changes
Refactored Shortcuts utility to properly store and clean up event listeners.
Wrapped videoRef.current access in a null-safe check before calling currentTime.
Added guard conditions to ensure both features degrade gracefully without errors.