Skip to content

fix(tldrawv2): disable hover, double click and background brush #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antobinary merged 1 commit into from
May 29, 2025
Merged

fix(tldrawv2): disable hover, double click and background brush #301

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 25 additions & 6 deletions src/components/tldraw_v2/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,10 @@ import {
import { ID } from 'utils/constants';
import storage from 'utils/data/storage';
import './index.scss';
import { getTldrawData, getViewBox, createTldrawImageAsset,
createTldrawBackgroundShape, createTldrawCursorShape } from 'utils/tldraw';
import {
getTldrawData, getViewBox, createTldrawImageAsset,
createTldrawBackgroundShape, createTldrawCursorShape
} from 'utils/tldraw';
import { buildFileURL } from 'utils/data';
import { isEmpty } from 'utils/data/validators';
import getCursor from './cursor';
Expand Down Expand Up @@ -58,7 +60,7 @@ const SlideData = (tldrawAPI) => {

const curPageId = tldrawAPI?.getCurrentPageId();
const assetId = AssetRecordType.createId(curPageId);

assets[`slide-background-asset-${id}`] = createTldrawImageAsset(assetId, buildFileURL(src), scaledWidth, scaledHeight)
shapes["slide-background-shape"] = createTldrawBackgroundShape(assetId, curPageId, scaledWidth, scaledHeight)

Expand Down Expand Up @@ -125,16 +127,17 @@ const TldrawPresentationV2 = ({ size }) => {
svgHeight / viewboxHeight
);

tldrawAPI?.setCamera({x, y, z: zoom});
tldrawAPI?.setCamera({ x, y, z: zoom });

}, [svgWidth, svgHeight, viewboxWidth, viewboxHeight, x, y, currentSlideIndex, tldrawAPI, size, result]);

React.useEffect(() => {
tldrawAPI?.updateInstanceState({ isReadonly: false });
// Remove all current shapes
const currentShapesSet = tldrawAPI?.getCurrentPageShapeIds() || (new Set());
const curentShapes = Array.from(currentShapesSet);
if (curentShapes.length > 0) { tldrawAPI?.deleteShapes(curentShapes); }

// Remove unnecessary properties from shapes to prevent Tldraw's validation from failing
const validatedShapes = Object.values(shapes).map((shape) => {
if ('isModerator' in shape) {
Expand All @@ -145,6 +148,7 @@ const TldrawPresentationV2 = ({ size }) => {

tldrawAPI?.createAssets(Object.values(assets));
tldrawAPI?.createShapes(validatedShapes);
tldrawAPI?.updateInstanceState({ isReadonly: true });
}, [tldrawAPI, shapes, assets]);

return (
Expand All @@ -168,12 +172,27 @@ const TldrawPresentationV2 = ({ size }) => {
app.setSelectedIds = () => { };
app.setHoveredId = () => { };
app.setSelectedShapes = () => { };
app.setHoveredShapes = () => { };
app.setHoveredShape = () => { };
app.onRightClick = () => { };
app.onDoubleClick = () => { };
app.onTripleClick = () => { };
app.onQuadrupleClick = () => { };
app.onWheel = () => { };
app.store.listen(
(entry) => {
const { changes } = entry;
const { updated } = changes;
const { 'instance:instance': instances } = updated;

if (instances && instances.length > 0) {
const newInstance = instances[1];
if (newInstance && newInstance.brush) {
app.updateInstanceState({ brush: null });
}
}
},
{ source: 'user' },
);
setTLDrawAPI(app);
}}
/>
Expand Down