Do not require email for signup with invite#5807
Open
byteplow wants to merge 2 commits intobigbluebutton:masterfrom
Open
Do not require email for signup with invite#5807byteplow wants to merge 2 commits intobigbluebutton:masterfrom
byteplow wants to merge 2 commits intobigbluebutton:masterfrom
Conversation
|
Collaborator
|
Thanks for this PR - this definitely improves the workflow for invited users. I'll try to get this into release 3.3.7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Currently, users must enter their email address when they sign up with an invitation. This email must match the email address for the invitation.
This pr changes that so that users do not have to enter their email address:
Potential issue: The invite token is used as a unique index by itself. The documentations for has_secure_token states:
I lack the understanding of active recording to judge, if this is the problem in this case.