Product name symbol handling #75
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: facundo.yuffrida <facundo.yuffrida@commerce.com>
|
Cursor Agent can help with this pull request. Just |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: facundo.yuffrida <facundo.yuffrida@commerce.com>
| import { useTracking } from '~/hooks/useTracking'; | ||
|
|
||
| const sanitizeProductNameForGeneration = (name: string) => | ||
| name.replaceAll('#', '').replace(/\s{2,}/g, ' ').trim(); |
There was a problem hiding this comment.
Make sure we have a test case validating this regex.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: JIRA_TOKEN
What/Why?
This PR modifies the
/productDescription/${id}endpoint's description generation flow. It addresses an issue where product names containing '#' symbols could interfere with AI description generation.To resolve this, the product name is now sanitized (all '#' symbols are removed) only for the AI generation request payload sent to
/api/generateDescription. The original product name, including '#' symbols, remains unchanged in the UI and product record, effectively "restoring" it after generation without any persistence.Rollout/Rollback
This is a code change. Rollout will be part of a standard deployment. Rollback would involve reverting the code.
Testing
@bigcommerce/team-data