-
Notifications
You must be signed in to change notification settings - Fork 62
chore(deps): bump react-dom and @types/react-dom #1794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
packages/big-design/package.json
Outdated
| "@types/node": "^20.12.7", | ||
| "@types/react": "^18.2.73", | ||
| "@types/react-beautiful-dnd": "^13.1.8", | ||
| "@types/react-dom": "^18.2.23", | ||
| "@types/react-dom": "^19.2.3", | ||
| "@types/styled-components": "^5.1.34", | ||
| "babel-jest": "^30.2.0", | ||
| "babel-plugin-styled-components": "^2.0.7", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: react-dom 19.2.0 is used with react 18.2.0 in devDependencies, creating an unsupported version mismatch for library testing.
Severity: MEDIUM | Confidence: High
🔍 Detailed Analysis
The pull request introduces an unsupported version mismatch in the devDependencies of published library packages (big-design, big-design-patterns, big-design-icons, big-design-theme). Specifically, react-dom is updated to 19.2.0 while react remains at 18.2.0. React and React DOM versions must match for compatibility, and this mismatch means the libraries will be tested against an unsupported configuration, potentially leading to unexpected behavior or build issues in the development environment.
💡 Suggested Fix
Either update react devDependency to ^19.2.0 to match react-dom 19.2.0, or revert react-dom devDependency to ^18.2.0 to match react 18.2.0. Update peerDependencies if react is updated to 19.x.
🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: packages/big-design/package.json#L74-L80
Potential issue: The pull request introduces an unsupported version mismatch in the
`devDependencies` of published library packages (`big-design`, `big-design-patterns`,
`big-design-icons`, `big-design-theme`). Specifically, `react-dom` is updated to
`19.2.0` while `react` remains at `18.2.0`. React and React DOM versions must match for
compatibility, and this mismatch means the libraries will be tested against an
unsupported configuration, potentially leading to unexpected behavior or build issues in
the development environment.
Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 3430709
50c8daf to
f9470eb
Compare
fab5686 to
8a84473
Compare
066c60e to
726dd7c
Compare
Bumps [react-dom](https://github.com/facebook/react/tree/HEAD/packages/react-dom) and [@types/react-dom](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react-dom). These dependencies needed to be updated together. Updates `react-dom` from 18.2.0 to 19.2.0 - [Release notes](https://github.com/facebook/react/releases) - [Changelog](https://github.com/facebook/react/blob/main/CHANGELOG.md) - [Commits](https://github.com/facebook/react/commits/v19.2.0/packages/react-dom) Updates `@types/react-dom` from 18.2.23 to 19.2.3 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react-dom) --- updated-dependencies: - dependency-name: react-dom dependency-version: 19.2.0 dependency-type: direct:production update-type: version-update:semver-major - dependency-name: "@types/react-dom" dependency-version: 19.2.3 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
726dd7c to
1e29227
Compare
Bumps react-dom and @types/react-dom. These dependencies needed to be updated together.
Updates
react-domfrom 18.2.0 to 19.2.0Release notes
Sourced from react-dom's releases.
... (truncated)
Changelog
Sourced from react-dom's changelog.
... (truncated)
Commits
8618113Bump scheduler version (#34671)1bd1f01Ship partial-prerendering APIs to Canary (#34633)2f0649a[Fizz] Removenonceoption from resume-and-prerender APIs (#34664)5667a41Bump next prerelease version numbers (#34639)e08f53bMatchreact-dom/statictest entrypoints and published entrypoints (#34599)8bb7241Bump useEffectEvent to Canary (#34610)83c88adHandle fabric root level fragment with compareDocumentPosition (#34533)68f00c9Release Activity in Canary (#34374)3168e08[flags] enable opt-in for enableDefaultTransitionIndicator (#34373)3434ff4Add scrollIntoView to fragment instances (#32814)Maintainer changes
This version was pushed to npm by react-bot, a new releaser for react-dom since your current version.
Updates
@types/react-domfrom 18.2.23 to 19.2.3Commits
You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)