chore(deps-dev): bump eslint from 8.57.1 to 9.39.0#416
chore(deps-dev): bump eslint from 8.57.1 to 9.39.0#416dependabot[bot] wants to merge 1 commit intomasterfrom
Conversation
Bumps [eslint](https://github.com/eslint/eslint) from 8.57.1 to 9.39.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Commits](eslint/eslint@v8.57.1...v9.39.0) --- updated-dependencies: - dependency-name: eslint dependency-version: 9.39.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
dependencies
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
| @@ -32,7 +32,7 @@ | |||
| "@babel/cli": "^7.27.1", | |||
| "@babel/core": "^7.27.1", | |||
There was a problem hiding this comment.
Bug: ESLint 9 upgrade breaks linting due to removed valid-jsdoc rule in eslint.config.js.
Severity: CRITICAL | Confidence: 0.95
🔍 Detailed Analysis
The eslint.config.js file contains a configuration for the valid-jsdoc rule. The pull request upgrades ESLint to v9.39.0. ESLint v9.0.0 and later versions have removed the valid-jsdoc rule. When ESLint v9.39.0 attempts to load eslint.config.js, it will encounter the non-existent rule, causing the linting process to terminate with an "unknown rule 'valid-jsdoc'" error. This will prevent successful linting and cause npm run lint to fail.
💡 Suggested Fix
Remove the valid-jsdoc rule configuration from eslint.config.js or replace it with an equivalent rule from eslint-plugin-jsdoc to ensure compatibility with ESLint v9.
🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: package.json#L33
Potential issue: The `eslint.config.js` file contains a configuration for the
`valid-jsdoc` rule. The pull request upgrades ESLint to v9.39.0. ESLint v9.0.0 and later
versions have removed the `valid-jsdoc` rule. When ESLint v9.39.0 attempts to load
`eslint.config.js`, it will encounter the non-existent rule, causing the linting process
to terminate with an "unknown rule 'valid-jsdoc'" error. This will prevent successful
linting and cause `npm run lint` to fail.
Did we get this right? 👍 / 👎 to inform future reviews.
|
Superseded by #417. |
Bumps eslint from 8.57.1 to 9.39.0.
Release notes
Sourced from eslint's releases.
... (truncated)
Commits
ac3a60d9.39.0e79017fBuild: changelog update for 9.39.0dfe3c1bchore: update@eslint/jsversion to 9.39.0 (#20270)2375a6dchore: package.json update for@eslint/jsreleased3e81e3docs: Always recommend to include a files property (#20158)15f5c7cfix: forward traversalstep.argsto visitors (#20253)5a1a534fix: allow JSDoc comments in object-shorthand rule (#20167)cc57d87feat: update error loc to key inno-dupe-class-members(#20259)a1f4e52chore: update@eslintdependencies (#20265)e86b813fix: Use more types from@eslint/core(#20257)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)Note
Upgrade
eslintto v9.39.0 and refresh related ESLint ecosystem dependencies in the lockfile.eslintto^9.39.0inpackage.json.package-lock.json(e.g.,@eslint/*,espree,eslint-scope,eslint-visitor-keys,@types/estree,acorn,file-entry-cache,flat-cache,globals).@humanfs/*,@eslint/config-*,@humanwhocodes/retry) and remove older ones no longer required (doctrine,graphemer,@nodelib/*, etc.).>=18.18).Written by Cursor Bugbot for commit 567c255. This will update automatically on new commits. Configure here.