Skip to content

Sync integrations makeswift #2723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chanceaclark merged 5 commits into from
Nov 18, 2025
Merged

Sync integrations makeswift #2723

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8fece6c
Revert "test(reviews): add e2e tests for reviews form (#2702)" (#2716)
chanceaclark Nov 17, 2025
ebd5993
chore: add 1.3.4 changeset (#2720)
chanceaclark Nov 17, 2025
c3fa141
Version Packages (`canary`) (#2721)
github-actions[bot] Nov 17, 2025
889cdc3
Merge branch 'canary' into sync-integrations-makeswift
chanceaclark Nov 17, 2025
dbafb31
chore: add 1.3.4 changeset
chanceaclark Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/shiny-clouds-flow.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@bigcommerce/catalyst-makeswift": patch
---

Noop release to account for typecheck issue.
2 changes: 1 addition & 1 deletion core/components/footer/index.tsx
View file
Open in desktop
Copy link
Contributor Author

@chanceaclark chanceaclark Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed to manually fix these issues as it wasn't fixed in the 1.3.3 version.

Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ import { readFragment } from '~/client/graphql';
import { revalidate } from '~/client/revalidate-target';
import { CurrencyCode } from '~/components/header/fragment';
import { logoTransformer } from '~/data-transformers/logo-transformer';
import { SiteFooter as FooterSection } from '~/lib/makeswift/components/site-footer';
import { getPreferredCurrencyCode } from '~/lib/currency';
import { SiteFooter as FooterSection } from '~/lib/makeswift/components/site-footer';

import { FooterFragment, FooterSectionsFragment } from './fragment';
import { AmazonIcon } from './payment-icons/amazon';
Expand Down
1 change: 1 addition & 0 deletions core/lib/makeswift/components/site-header/client.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ type ContextProps = Omit<HeaderSectionProps, 'navigation'> & {

const PropsContext = createContext<ContextProps>({
navigation: {
giftCertificatesHref: '',
accountHref: '',
cartHref: '',
searchHref: '',
Expand Down
96 changes: 0 additions & 96 deletions core/tests/ui/e2e/reviews.spec.ts
View file
Open in desktop

This file was deleted.