Skip to content

fix: Sort product IDs before sending requests to BC so cache can be utilized #2793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jayeshbharadva wants to merge 2 commits into
base: integrations/makeswift
Choose a base branch
from
Open

fix: Sort product IDs before sending requests to BC so cache can be utilized #2793

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
512dce7
fix: sort product id before request to hit cache
jayeshbharadva Dec 19, 2025
895ef50
Changeset added
jayeshbharadva Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .changeset/heavy-hotels-lie.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,4 @@
---

Fix sort order of `additionalProducts` prop in `ProductsCarousel` Makeswift component.
Sort product IDs before sending requests to BC so cache can be utilized in `ProductCarousel`
2 changes: 1 addition & 1 deletion core/lib/makeswift/utils/use-products.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export function useProducts({ collection, collectionLimit = 20, additionalProduc

const searchParams = new URLSearchParams();

searchParams.append('ids', additionalProductIds.join(','));
searchParams.append('ids', additionalProductIds.sort().join(','));
searchParams.append('locale', locale);

const additionalProductsUrl = `/api/products/ids?${searchParams.toString()}`;
Expand Down